Rename param implementation #1792
Merged
+238
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBurmark
force-pushed
the
feature/burmark1/param_rename
branch
2 times, most recently
from
3a4a65b to
c63cf3e
Compare
Prefix helper methods dealign with many paramaters with params_. This makes it much easier to differentiate them from other functions and variables with the same name.
This makes this use normal overloading resolution instead of trying to take everything through the RAJA::detail namespace. Theoretically this should allow a user could make their own param.
MrBurmark
force-pushed
the
feature/burmark1/param_rename
branch
from
c63cf3e to
3ed1b70
Compare
adayton1
reviewed
Feb 19, 2025
adayton1
reviewed
Feb 19, 2025
adayton1
reviewed
Feb 19, 2025
adayton1
approved these changes
Feb 19, 2025
rchen20
reviewed
Feb 19, 2025
rchen20
reviewed
Feb 19, 2025
rchen20
approved these changes
Feb 19, 2025
mdavis36
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename param implementation
Prepend param_ to the init, combine, and resolve overloads used to implement the params interface.
This avoids having to make a call to a specific function in detail and should allow the interface to be more extensible. Perhaps even to the point of letting users add params that could look at things like the cuda/hip launch parameters.
Also pass the policy by value to avoid having to specifying the template parameter explicitly.