Finish fix for #416

[gilbert]

See here for details: #416 (comment). In a nutshell, you only need globalThis.

[CLAassistant]

All committers have signed the CLA.

[Ansonhkg]

Hey, thanks for the PR. I'm not sure if this will completely fix the issue, because we are now using cross-fetch PR, which uses global under the hood. Therefore, the same problem might occur.

May I suggest to configure your build tool to shim the global object while we investigate this issue?

eg. in vite

import { defineConfig } from "vite";
import react from "@vitejs/plugin-react-swc";


export default defineConfig({
  plugins: [react()],
  define: {
    global: "window",
  },
});

cc @MaximusHaximus @joshLong145 can you take a look?

[gilbert]

Indeed, I'm upgrading to lit v6 and am now running into the cross-fetch issue.

Either way, there's no reason to use global over globalThis, and I see a4dd28f implemented this fix. Thanks!

[Ansonhkg]

cross-fetch

Thanks, we are considering ripping out cross-fetch completely, as it's too hard to satisfy all environments, we will just let users to polyfill themselves and provide configuration guides in the docs instead.

I could however publish a temp. version for you without cross-fetch if that would help?