-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The 1-hour-off bug #1
Comments
Hi, thanks for reporting. I'll take a look at it. |
Hi Kaens, I was able to reproduce this error. It looks like the filetime in the zip archive is not converted to utc at unpacking but ntfs uses utc. So as I played around with timezones the displayed "current file date" and time was everytime exactly the same after updating, regardless of the timezone. But it changes when I changed timezones in windows. So the 1-hour gap changed with timezones after a new update. A quick workaround was to set the file time to the current after unpacking. This is done in the batch file, so please try the latest I have a better fix in mind, but I need some time for this. I'll leave this issue open until I've done it, but for now everything should work. |
Next version will check against the commit hash instead of the file date, so I think this issue can be closed. Maybe I'll include a widget in the updater dialog which displays the latest commits too. |
After having updated mere moments ago:
I recall it might have something to do with the way NTFS works. Maybe not, though.
The text was updated successfully, but these errors were encountered: