Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 1-hour-off bug #1

Closed
Kaens opened this issue Jul 4, 2018 · 3 comments
Closed

The 1-hour-off bug #1

Kaens opened this issue Jul 4, 2018 · 3 comments
Labels
bug Something isn't working confirmed

Comments

@Kaens
Copy link

Kaens commented Jul 4, 2018

After having updated mere moments ago:
Something like this
I recall it might have something to do with the way NTFS works. Maybe not, though.

@LFriede
Copy link
Owner

LFriede commented Jul 4, 2018

Hi, thanks for reporting. I'll take a look at it.

LFriede added a commit that referenced this issue Jul 16, 2018
@LFriede
Copy link
Owner

LFriede commented Jul 16, 2018

Hi Kaens, I was able to reproduce this error. It looks like the filetime in the zip archive is not converted to utc at unpacking but ntfs uses utc. So as I played around with timezones the displayed "current file date" and time was everytime exactly the same after updating, regardless of the timezone. But it changes when I changed timezones in windows. So the 1-hour gap changed with timezones after a new update. A quick workaround was to set the file time to the current after unpacking. This is done in the batch file, so please try the latest _update.bat I commited, then let the plugin apply an update and it should do what it supposed to. Looks like I didn't notice it because my timezone matches the one of the zip files.

I have a better fix in mind, but I need some time for this. I'll leave this issue open until I've done it, but for now everything should work.

@LFriede LFriede added bug Something isn't working confirmed labels Jul 16, 2018
@LFriede
Copy link
Owner

LFriede commented Jul 22, 2018

Next version will check against the commit hash instead of the file date, so I think this issue can be closed. Maybe I'll include a widget in the updater dialog which displays the latest commits too.

@LFriede LFriede closed this as completed Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
None yet
Development

No branches or pull requests

2 participants