Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code changes for generation of NYC walk transit trips #3493

Draft
wants to merge 205 commits into
base: develop
Choose a base branch
from
Draft

Code changes for generation of NYC walk transit trips #3493

wants to merge 205 commits into from

Conversation

nikolayilyin
Copy link
Collaborator

@nikolayilyin nikolayilyin commented Mar 23, 2022 •
edited
Loading

  • filling-in modes during generation of secondary activities
  • scripts to generate trips and list of OD pairs from plans (to generate skims only for required OD pairs)
  • usage of parking cost in DestinationChoiceModel
  • crowding level in OD skims

This change is Reviewable

zneedell and others added 30 commits December 2, 2021 17:22
@zneedell
start choosing modes
4da4874
@zneedell
gather legs from subtours and mandatory trips
3def0de
@zneedell
compilation fixes
f9285ba
@zneedell
logic fix
258b6ea
@zneedell
false by default
c00593b
@Xuan-1998
scalafmt
aa65866
@nikolayilyin
Merge branch 'develop' into zn/#3376-generate-activity-plans-with-modes
065c1ec
@nikolayilyin
Merge branch 'inm/terminate-simulation-at-beginning-of-simulation' in…
99e8a87 
…to zn/#3376-generate-activity-plans-with-modes
@nikolayilyin
data for test
5b877b9
@nikolayilyin
testing of simulation stop with secondary activities
104c831
@nikolayilyin
Merge branch 'inm/terminate-simulation-at-beginning-of-simulation' in…
cd67467 
…to zn/#3376-generate-activity-plans-with-modes
@nikolayilyin
Merge remote-tracking branch 'origin/develop' into zn/#3376-generate-…
acbc7f1 
…activity-plans-with-modes
@nikolayilyin
test for secondary activities generation with/without modes
3e76bc9
@zneedell
fix structure of output plans, deal with vehicle availability
3a636dd
@zneedell
consider non-car modes too after returning home
9a086f1
@JustinPihony
fmt
99b7fea
@nikolayilyin
test for modes in generated plans
14ba8ab
@nikolayilyin
Merge branch 'zn/#3376-generate-activity-plans-with-modes' into inm/n…
7b8289f 
…yc-code-change-with-plans-generation
@nikolayilyin
run params
695b3e5
@nikolayilyin
parallel approach test
b60af66
@nikolayilyin
typo
bfebcd7
@nikolayilyin
a utility to generate all OD TAZ pairs from plans
b1dd0ec
@nikolayilyin
a description
a8ff68c
@nikolayilyin
typo
fc53b6c
@nikolayilyin
writing output into file
39bca1f
@nikolayilyin
refactoring
df11aa8
@nikolayilyin
bugfix
c1b3166
@nikolayilyin
additional coordinate transformation if required
a8e45de
@nikolayilyin
bugfix
3a6caa7
@nikolayilyin
bugfix
ab6d529
@nikolayilyin
Copy link
Collaborator Author

test!

@nikolayilyin
Copy link
Collaborator Author

test!

nikolayilyin and others added 24 commits July 17, 2022 19:56
@nikolayilyin
fix for reader if there is not-a-number in column
91335a8
@nikolayilyin
a fix for missing mode in modemap
f6fee4b
@nikolayilyin
better warn message
570477c
@nikolayilyin
Merge remote-tracking branch 'origin/develop' into inm/nyc-code-chang…
ee9c3f6 
…e-with-plans-generation
@nikolayilyin
cost analysis update
fc78763
@zneedell
Merge remote-tracking branch 'origin/develop' into inm/nyc-code-chang…
ca1b04c 
…e-with-plans-generation
@zneedell
Merge remote-tracking branch 'origin/develop' into inm/nyc-code-chang…
2970eed 
…e-with-plans-generation
@nikolayilyin
test configs and scenario data
507d2b4
@nikolayilyin
better percent display
1b54d00
@nikolayilyin
a fix for generated urbansim plans
4f8e925
@nikolayilyin
Merge branch 'inm/nyc-code-change-with-plans-generation' of https://g…
6fb360f 
…ithub.com/LBNL-UCB-STI/beam into inm/nyc-code-change-with-plans-generation
@nikolayilyin
empty commit for deploy
f6df8ec
@nikolayilyin
bugfix
9dd3308
@nikolayilyin
fix for missing parking stall
b93e6a0
@nikolayilyin
refactoring
f2a75bf
@nikolayilyin
an attempt to fix missing vehicle manager
dceb5f7
@nikolayilyin
bugfix
014f13f
@nikolayilyin
Merge remote-tracking branch 'origin/develop' into inm/nyc-code-chang…
adfbfd3 
…e-with-plans-generation
@nikolayilyin
jupyter files
50714d5
@nikolayilyin
nyc collaboration jupyter notebook
cf7f0f3
@nikolayilyin
notebook clear
cbfab52
@zneedell
Merge remote-tracking branch 'origin/develop' into inm/nyc-code-chang…
2b9cef6 
…e-with-plans-generation

# Conflicts:
#	src/main/scala/beam/agentsim/agents/PersonAgent.scala
@nikolayilyin
a fix for exceptions happen before logger is configured
ce8f75c
Added trip id to transitVehicleTypesByRoute File
48bd158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaopen dimaopen Awaiting requested review from dimaopen

@JustinPihony JustinPihony Awaiting requested review from JustinPihony

At least 1 approving review is required to merge this pull request.

Assignees

@nikolayilyin nikolayilyin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikolayilyin @zneedell @Xuan-1998 @JustinPihony @g-derzhavets