Current trip mode basing on current tour mode #3476

dimaopen · 2022-02-25T13:04:01Z

Instead of setting mode for the whole tour (Home -> Work -> Shopping -> Home) and use it for each individual trip now we use current tour mode for getting the right current trip mode.
Also HouseholdFleetManager doesn't return a personal vehicle to persons that are not at home.

This change is

zneedell

Logic all looks good to me. I left one main suggestion for trying to make use of the Tour class that already extends PlanElement, which might give a more consistent way of keeping track of tour and trip modes.

For the record, my longer term plan/hope here is that we can eventually implement a tour mode choice that happens before trip mode choice in chooses mode. E.g. when someone comes to a leg in their plans without a tour mode set, they make an initial tour mode choice based on the skims looking at all of the trips in the tour and then set the tour mode there, then they can go about the individual trip mode choices in real time when they get to them. We could also improve the existing tour formation logic here to allow for nested subtours and/or reading in tour modes (potentially without trip modes) from activitysim.

BUT that's all down the road, I think this will get us 90+% of what we want.

zneedell · 2022-02-28T19:10:37Z

src/main/scala/beam/agentsim/agents/PersonAgent.scala

@@ -475,6 +478,30 @@ class PersonAgent(
    }
  }

+  def isFirstTripWithinTour(personData: BasePersonData, nextAct: Activity): Boolean = {


I'm wondering if we could replace this check with instead checking if the current activity == home. I'm thinking of a case where someone did something like home -> work -> home -> shop -> home. We'd want them to be able to pick up their car for the second home -> shop -> home tour, for instance

Later edit -- if we rely on the Tour class in BeamPlan this gets easier, I think

Tours are created basing on "Home" activity:

beam/src/main/scala/beam/agentsim/agents/planning/BeamPlan.scala

Line 118 in cb98851

if (activity.getType.equalsIgnoreCase("home")) {

So I think it's generally the same (current activity == home and isFirstTripWithinTour).

That isFirstTripWithinTour method is not used anywhere and is kept for symmetry.

zneedell · 2022-03-01T19:01:03Z

src/main/scala/beam/agentsim/agents/PersonAgent.scala

-              case _ =>
-                data.currentTourMode.orElse(modeOfNextLeg)
-            },
+            // We do not stick to current tour mode


I'm wondering if here we can make use of the currentTour method defined above to take advantage of the tour structure already in BeamPlan.scala. It might take some archaeology to figure out how exactly everything was intended to function, but it looks like the strategies map in a BeamPlan allows for modes to be stored both for individual trips/legs and for tours.

So, I'm wondering if something like

val tourModeOption = _experiencedBeamPlan.getStrategy(currentTour(data), classOf[ModeChoiceStrategy])

would get the current tour mode, and we could do something similar with putStrategy when the initial trip mode is chosen and we want to set the tour mode.

Replayed in the comment bellow.

zneedell · 2022-03-01T19:24:03Z

src/main/scala/beam/agentsim/agents/PersonAgent.scala

@@ -587,15 +614,10 @@ class PersonAgent(
        val nextCoord = nextActivity(data).get.getCoord


Now that I look at it, I wonder if the definition of modeOfNextLeg above can be replaced with

val modeOfNextLeg = _experiencedBeamPlan.getStrategy(nextAct, classOf[ModeChoiceStrategy])

Replayed in the comment bellow.

zneedell · 2022-03-04T22:12:39Z

@dimaopen -- I played around with making some of the changes involving _experiencedBeamPlan in a new branch based off this one here: https://github.com/LBNL-UCB-STI/beam/tree/zn/do/%233442-current-trip-tour-mode.

I'd be curious to see if you think the logic there makes sense and aligns with what you were thinking

Xuan-1998 · 2022-03-18T20:33:30Z

Test!

JustinPihony

Deferring to Zach's comments moreso. Mine are not blockers.

src/main/scala/beam/agentsim/agents/modalbehaviors/ChoosesMode.scala

JustinPihony · 2022-03-21T02:21:12Z

src/main/scala/beam/agentsim/agents/modalbehaviors/ChoosesMode.scala

+    val replanningIsAvailable =
+      personData.numberOfReplanningAttempts < beamServices.beamConfig.beam.agentsim.agents.modalBehaviors.maximumNumberOfReplanningAttempts
+    (personData.currentTripMode, personData.currentTourMode) match {
+      case (_, Some(CAR | BIKE)) if personData.currentTourPersonalVehicle.isDefined => personData.currentTourMode


This seems also a new behavior - as long as tour/trip aren't getting confused....I guess this raises the question of naming - should a different name be used so somebody doesn't accidentally use the wrong variable.

You are right. @zneedell What do you think about currentTourMode vs currentTripMode names?

dimaopen · 2022-03-22T14:21:10Z

I'd be curious to see if you think the logic there makes sense and aligns with what you were thinking

Generally it looks good. Though we have some kind of duplication here: personData.(currentTripMode, currentTourMode) and _experiencedBeamPlan.getStrategy(currentTour/Trip, classOf[ModeChoiceStrategy]) needs to hold the same data (and also be updated in the right order).
I think that we need to remove one or the other.
By the way it already has some inconsistency. I did some sf-light runs using this new approach and you can see that a person forgot their car and used ridehail here:

If we look at a similar run with the old approach we can see that the tour mode is right:

Let me know what you think.

…rip-tour-mode # Conflicts: # src/main/scala/beam/agentsim/agents/modalbehaviors/ChoosesMode.scala

dimaopen · 2022-03-22T15:00:24Z

@zneedell
I just found that the current PR also produces some inconsistent trips. You can see WALK in the middle of the trip.

Probably I need to fix this behaviour.

Xuan-1998 · 2022-03-22T15:34:22Z

@zneedell
I just found that the current PR also produces some inconsistent trips. You can see WALK in the middle of the trip.

Probably I need to fix this behaviour.

Just out of curiosity here, so based on my understanding, we are forcing agents to use car when they depart with a car on the first Home trip? Why is this the case? I think it makes sense to me to let agents use other modes in the middle but just bring their car with them home. Correct me if I understand anything wrong here..

zneedell · 2022-03-22T15:46:26Z

@Xuan-1998 I think you're totally right that what you've described would be the ideal behavior. The logic to do it correctly is going to be a little tricky, though, and AFAIK it hasn't been implemented here yet. Basically, doing it as you describe I think would require scanning forward in an agent's plan to check whether the agent returns to the same place later in the day and then only allowing a non-car trip if we know they're going to be able to pick up their car later.

So I think that would be really cool if we could get that working, but I'd also be OK with implementing a half step here where we don't allow for that yet. But I do think that one of the potential benefits of going down the _experiencedBeamPlan.getStrategy route is that it might allow for this more complex logic

zneedell · 2022-03-23T00:48:45Z

OK I made some updates to https://github.com/LBNL-UCB-STI/beam/tree/zn/do/%233442-current-trip-tour-mode that seem to help (at least in my branch I had been saving the tripMode rather than tourMode to the tourMode column of events.csv, plus adding an explicit filter of the itineraries for mode choice based on the current tour mode). The columns here are the tour mode and the rows here are the actual mode taken:

(not sure where the walk trips with the car tour mode come from)

Agreed with Dima that we probably want to either go with this solution or doing it based on ChoosesModeData rather than trying to do both, and I'm definitely not convinced that this is the right way to do it, but I'll do a little more testing of it this week.

…ct trip mode for teleport modes.

dimaopen · 2022-03-24T09:42:00Z

Test!

dimaopen · 2022-03-25T08:46:31Z

Test!

dimaopen · 2022-03-25T09:25:29Z

Test!

dimaopen · 2022-03-25T13:22:06Z

Test!

dimaopen · 2022-03-25T14:33:40Z

Test now!

dimaopen · 2022-03-25T15:12:26Z

Test now!

JustinPihony · 2022-04-29T21:01:08Z

src/main/scala/beam/agentsim/agents/modalbehaviors/ChoosesMode.scala

+      case data: ChoosesModeData
+          if data.personData.currentTourPersonalVehicle.isDefined &&
+            (
+              data.personData.currentTourMode.exists(mode => mode == CAR || mode == BIKE) ||


This double exists against the same variable still is there - and is complicated by an &&. Can you add parentheses to delineate the intent please

It looks like it was re-added as part of de1684a

dimaopen · 2022-06-07T06:39:29Z

src/main/scala/beam/agentsim/agents/household/HouseholdFleetManager.scala

-          case firstVehicle :: rest =>
+          //in case of replanning because of TRANSIT failure WALK_TRANSIT is used
+          //but we may want to introduce maxWalkingDistance and check that the agent is close enough to the vehicle
+          case firstVehicle :: rest if atHome(originActivity) =>


Providing a private vehicle only when the person is at home might be a wrong idea. It may lead to increased number of "Long waling trips".

dimaopen added 2 commits February 25, 2022 11:44

currentTripMode vs currentTourMode

c40970f

Provide personal vehicle only when agent is at home

4d2e375

dimaopen requested review from JustinPihony, nikolayilyin and zneedell February 25, 2022 13:04

dimaopen added the AgentSim label Feb 25, 2022

dimaopen linked an issue Feb 25, 2022 that may be closed by this pull request

Walk issue in ChoosesMode #3441

Open

zneedell requested changes Mar 1, 2022

View reviewed changes

zneedell reviewed Mar 1, 2022

View reviewed changes

JustinPihony reviewed Mar 21, 2022

View reviewed changes

Merge remote-tracking branch 'origin/develop' into do/#3441-current-t…

7cfbc79

…rip-tour-mode # Conflicts: # src/main/scala/beam/agentsim/agents/modalbehaviors/ChoosesMode.scala

dimaopen added 4 commits March 23, 2022 10:47

Introduced personalVehicleModes

a58eef5

Better handling of situation when we do the second mode choice

93566b6

Using currentTripMode to request available vehicles

691456f

Using correctedCurrentTripMode when getting available vehicles. Corre…

6d063a9

…ct trip mode for teleport modes.

Fixed not using current tour personal vehicle. Fixed trip/tour field.

de1684a

JustinPihony reviewed Apr 29, 2022

View reviewed changes

JustinPihony mentioned this pull request Apr 30, 2022

Using ModeChoiceStrategy to keep current tour/trip mode #3497

Closed

dimaopen commented Jun 7, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Current trip mode basing on current tour mode #3476

Current trip mode basing on current tour mode #3476

dimaopen commented Feb 25, 2022 •

edited by colinsheppard

Loading

zneedell left a comment

zneedell Feb 28, 2022

zneedell Mar 1, 2022

dimaopen Mar 22, 2022

dimaopen Mar 28, 2022

zneedell Mar 1, 2022

dimaopen Mar 22, 2022

zneedell Mar 1, 2022

dimaopen Mar 22, 2022

zneedell commented Mar 4, 2022

Xuan-1998 commented Mar 18, 2022

JustinPihony left a comment

JustinPihony Mar 21, 2022

dimaopen Mar 22, 2022

dimaopen commented Mar 22, 2022

dimaopen commented Mar 22, 2022

Xuan-1998 commented Mar 22, 2022

zneedell commented Mar 22, 2022

zneedell commented Mar 23, 2022 •

edited

Loading

dimaopen commented Mar 24, 2022

dimaopen commented Mar 25, 2022

dimaopen commented Mar 25, 2022

dimaopen commented Mar 25, 2022

dimaopen commented Mar 25, 2022

dimaopen commented Mar 25, 2022

JustinPihony Apr 29, 2022

JustinPihony Apr 30, 2022

dimaopen Jun 7, 2022

		@@ -587,15 +614,10 @@ class PersonAgent(
		val nextCoord = nextActivity(data).get.getCoord

Current trip mode basing on current tour mode #3476

Are you sure you want to change the base?

Current trip mode basing on current tour mode #3476

Conversation

dimaopen commented Feb 25, 2022 • edited by colinsheppard Loading

zneedell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zneedell commented Mar 4, 2022

Xuan-1998 commented Mar 18, 2022

JustinPihony left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dimaopen commented Mar 22, 2022

dimaopen commented Mar 22, 2022

Xuan-1998 commented Mar 22, 2022

zneedell commented Mar 22, 2022

zneedell commented Mar 23, 2022 • edited Loading

dimaopen commented Mar 24, 2022

dimaopen commented Mar 25, 2022

dimaopen commented Mar 25, 2022

dimaopen commented Mar 25, 2022

dimaopen commented Mar 25, 2022

dimaopen commented Mar 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dimaopen commented Feb 25, 2022 •

edited by colinsheppard

Loading

zneedell commented Mar 23, 2022 •

edited

Loading