Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust gas consumption for external handlers #305

Merged
merged 16 commits into from
Jan 25, 2023
Merged

Adjust gas consumption for external handlers #305

merged 16 commits into from
Jan 25, 2023

Conversation

sgladkov
Copy link
Contributor

@sgladkov sgladkov commented Nov 4, 2022 •
edited by tbssajal
Loading

Tested with hardfork

@sgladkov sgladkov marked this pull request as draft November 4, 2022 13:59
@tbssajal tbssajal force-pushed the gas_consumption branch 2 times, most recently from 7166089 to 2718db3 Compare January 18, 2023 20:54
@tbssajal tbssajal marked this pull request as ready for review January 19, 2023 08:13
@tbssajal
Copy link
Collaborator

tbssajal commented Jan 19, 2023 •
edited
Loading

  • Using gas GasMetering.LoadStorageGasCost for any db read
  • Using gas GasMetering.SaveStorageGasCost for any db write
  • Added GasMetering.InvokeContractGasCost = 200_000 for DoInternalCall and InvokeContract methods
  • Added GasMetering.SetReturnGasCost = 100 to set return
  • Added GasMetering.GetGasLeftGasCost = 100 to get gas left
  • Increased CopyFromMemoryGasPerByte, CopyToMemoryGasPerByte, RecoverGasCost, VerifyGasCost

@tbssajal tbssajal requested review from soloway2010 and dkhrustalev and removed request for Anachor January 19, 2023 08:41
@tbssajal
Copy link
Collaborator

tbssajal commented Jan 23, 2023 •
edited
Loading

Need to calculate hardfork height before release

@tbssajal tbssajal merged commit a381e5b into dev Jan 25, 2023
@tbssajal tbssajal deleted the gas_consumption branch January 25, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbssajal tbssajal Awaiting requested review from tbssajal

@soloway2010 soloway2010 Awaiting requested review from soloway2010

@dkhrustalev dkhrustalev Awaiting requested review from dkhrustalev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgladkov @tbssajal