添加CascadeForestClassifier类对cross_val_score交叉验证的支持。
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
给`BaseCascadeForest`添加基类`BaseEstimator`以包含`get_params`方法; 对`CascadeForestClassifier`添加`ClassifierMixin`基类以包含`score`方法。
|
Hi @pjgao, thanks for the PR! It looks like there is a problem on flake8 formatting, you can check the logs from the CI: Code-Quality for details. In addition, do not forget to add your contribution and name in |
|
Great! I will have a final check tomorrow, and merge it if there is no problem ;-) Once again, thanks for the PR! |
|
Hi @pjgao, I have made some edits on your code:
Let me know if you are OK with these changes ;-) I will merge this PR if you have no problem. |
|
It looks great, now we can use <tab> to autocomplete the params. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
给
BaseCascadeForest添加基类BaseEstimator以包含get_params方法; 对CascadeForestClassifier添加ClassifierMixin基类以包含score方法。Related Issue: #2