MAPREDUCE-7358. Clean shared state pollution to avoid flaky test testMR#2
Open
MAPREDUCE-7358. Clean shared state pollution to avoid flaky test testMR#2
Conversation
LALAYANG
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar to merged apache#2499, but for a different test.
Link to issue: https://issues.apache.org/jira/browse/MAPREDUCE-7358
What is the purpose of this change
This PR is to fix a non-idempotent test
org.apache.hadoop.mapred.TestClusterMRNotification.testMR.Why the test failed
The root cause for the failure is that this test does not clean
NotificationServlet.counterat the end, which pollutes the shared state. It may be better to clean state pollutions so that some other tests won't fail in the future due to the shared state polluted by this test.Reproduce test failure
Run the test twice in the same JVM.
Expected result
The test should run successfully without any failures.
Actual result
Failure from test run:
NotificationTestCase.testMR:174 expected:<2> but was:<8>Fix
Clear the value of
NotificationServlet.counterat the end of the test.