-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eaf controlled vocabulary #362
base: master
Are you sure you want to change the base?
Conversation
marianne-m
commented
Feb 24, 2022
•
edited by LoannPeurey
Loading
edited by LoannPeurey
- check that all the annotations use labels defined in the controlled vocabulary
- import the description of each label of the controlled vocabulary and store it somewhere
- documentation
- tests
Few comments on this PR!
What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion: add the annotation set (since different sets may have different schemes for the eaf right) and the raw filename of the eaf (for debugging purposes mostly) to the controlled voc metadata.
(All this is up to you of course! Just my advice)
I am in favour of putting the controlled vocabulary metadata inside the metadata folder. I find it simpler to have everything stored in one place rather than in several places. I agree it's important to save the name of the annotation set in the metadata file. But I'm not convinced we should also save the raw_filename of all the files using this annotation scheme as all the files of a given set should be using it anyway... |
I agree that ideally all the files should share the same vocabulary within a set, but for debugging purposes it is still useful (I think) to keep track of where the information was retrieved. That does not mean keeping a duplicate entry for each file (so that should not pose any readability problem). Also this should allow to spot mismatches between annotations within a set if they occur. If you can't see a situation where this may be useful then forget about it! It's just an idea:) |