Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git crash when looking for updates of this plugin via lazy #1068

Closed
kmoschcau opened this issue Nov 29, 2023 · 10 comments
Closed

Git crash when looking for updates of this plugin via lazy #1068

kmoschcau opened this issue Nov 29, 2023 · 10 comments

Comments

@kmoschcau
Copy link

kmoschcau commented Nov 29, 2023

When I recently tried to check for updates of this plugin via lazy, git crashes on the first attempt, then fails on a second attempt because of a lock file that has not been cleaned up. The lock file in question is .git/objects/info/commit-graphs/commit-graph-chain.lock

My hunch is, this is because of the branch named windows-😐.

I've had this happen on both Windows and Linux, both running git version 2.43.0. The only place where it didn't happen was in WSL, where git is of version 2.34.1.

Here is the related Lazy issue: folke/lazy.nvim#1204

@L3MON4D3
Copy link
Owner

L3MON4D3 commented Nov 29, 2023

Oh okay.. I'd be a bit surprised if it was caused by a branch-name, but I'll delete it just in case, it's old anyway.
Was it a one-time ocurrence, or could you reproduce it?

@kmoschcau
Copy link
Author

I can repro it each time I check for a new version. It's a single button press.

@L3MON4D3
Copy link
Owner

I've deleted the branch in question, does it still occur?

@kmoschcau
Copy link
Author

I just checked again on the Windows machine and it does still occur. Even after completely fresh checkout. The initial clone, including submodule works. Just checking for updates fails. I'll have a look later on the Linux machine.

@ZeekDaGeek
Copy link

ZeekDaGeek commented Dec 2, 2023

I know this really isn't a satisfying solution, it doesn't help you prevent it from happening again, but:

Placing your cursor over LuaSnip and pressing x to delete, then pressing I (capital i) to install again solved the problem.

So basically, have you tried turning it off and on again?

EDIT: I'm sorry I think my error might actually be more related to #1071 then this one, I should have looked harder, sorry.

@kmoschcau
Copy link
Author

@ZeekDaGeek I did that already and that does allow updating. Though my problem is that I'd have to do that every time just to check for updates.
@L3MON4D3 I realize I didn't get back to you, the issue is still present on the Linux machine as well. Though at this point I think this is more of an issue in Lazy than with LuaSnip. LuaSnip is just the only plugin (I think) that uses submodules in my plugin list. So seems to me this is something that Lazy does when checking submodules, that broke in newer Git versions.

@ghost
Copy link

ghost commented Dec 7, 2023

For whatever its worth, this is happening to me as well.

@veejaypee
Copy link

reinstalling the plugin with x I on lazy fixed this.

@kmoschcau
Copy link
Author

reinstalling the plugin with x I on lazy fixed this.

As already stated before it allows you to do the update once, but it does not fix the underlying issue of the check for updates failing.

andreaswachowski added a commit to andreaswachowski/dotfiles that referenced this issue Dec 17, 2023
@kmoschcau
Copy link
Author

Ultimately we found a workaround in the lazy thread: folke/lazy.nvim#1204 (comment)

I tested it myself and it prevents the error from occurring. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants