fix #1070 (nbt): ListBinaryTag is weakly immutable

nbt/src/main/java/net/kyori/adventure/nbt/CompoundBinaryTagImpl.java

@@ -234,7 +234,7 @@ public double getDouble(final @NotNull String key, final double defaultValue) {
   private CompoundBinaryTag edit(final Consumer<Map<String, BinaryTag>> consumer) {
     final Map<String, BinaryTag> tags = new HashMap<>(this.tags);
     consumer.accept(tags);
-    return new CompoundBinaryTagImpl(tags);
+    return new CompoundBinaryTagImpl(new HashMap<>(tags)); // explicitly copy
   }
 
   @Override

nbt/src/main/java/net/kyori/adventure/nbt/CompoundTagBuilder.java

@@ -74,6 +74,6 @@ private Map<String, BinaryTag> tags() {
   @Override
   public @NotNull CompoundBinaryTag build() {
     if (this.tags == null) return CompoundBinaryTag.empty();
-    return new CompoundBinaryTagImpl(new HashMap<>(this.tags));
+    return new CompoundBinaryTagImpl(new HashMap<>(this.tags)); // explicitly copy
   }
 }

nbt/src/main/java/net/kyori/adventure/nbt/ListBinaryTag.java

@@ -23,6 +23,7 @@
  */
 package net.kyori.adventure.nbt;
 
+import java.util.ArrayList;
 import java.util.List;
 import java.util.function.Consumer;
 import java.util.stream.Stream;
@@ -99,7 +100,7 @@ public interface ListBinaryTag extends ListTagSetter<ListBinaryTag, BinaryTag>,
   static @NotNull ListBinaryTag listBinaryTag(final @NotNull BinaryTagType<? extends BinaryTag> type, final @NotNull List<BinaryTag> tags) {
     if (tags.isEmpty()) return empty();
     if (type == BinaryTagTypes.END) throw new IllegalArgumentException("Cannot create a list of " + BinaryTagTypes.END);
-    return new ListBinaryTagImpl(type, tags);
+    return new ListBinaryTagImpl(type, new ArrayList<>(tags)); // explicitly copy
   }
 
   /**

nbt/src/main/java/net/kyori/adventure/nbt/ListBinaryTagImpl.java

@@ -143,7 +143,7 @@ private ListBinaryTag edit(final Consumer<List<BinaryTag>> consumer, final @Null
     if (maybeElementType != null && elementType == BinaryTagTypes.END) {
       elementType = maybeElementType;
     }
-    return new ListBinaryTagImpl(elementType, tags);
+    return new ListBinaryTagImpl(elementType, new ArrayList<>(tags)); // explicitly copy
   }
 
   @Override

nbt/src/main/java/net/kyori/adventure/nbt/ListTagBuilder.java

@@ -67,6 +67,6 @@ final class ListTagBuilder<T extends BinaryTag> implements ListBinaryTag.Builder
   @Override
   public @NotNull ListBinaryTag build() {
     if (this.tags == null) return ListBinaryTag.empty();
-    return new ListBinaryTagImpl(this.elementType, new ArrayList<>(this.tags));
+    return new ListBinaryTagImpl(this.elementType, new ArrayList<>(this.tags)); // explicitly copy
   }
 }