Skip to content

Conversation

thejamescollins
Copy link
Contributor

@thejamescollins thejamescollins commented May 1, 2025

Adds support for Shopify's Managed App Installation and its Session Token Exchange.

See #409 for detailed discussions and steps.

Fixes #409

@thejamescollins thejamescollins changed the title Perform Managed Installation Session Token Exchange [WIP] Adds support for Shopify's Managed App Installation including Session Token Exchange [WIP] May 5, 2025
@thejamescollins thejamescollins marked this pull request as ready for review May 5, 2025 08:55
@thejamescollins thejamescollins changed the title Adds support for Shopify's Managed App Installation including Session Token Exchange [WIP] Adds support for Shopify's Managed App Installation including Session Token Exchange May 5, 2025
@thejamescollins
Copy link
Contributor Author

Hi @thesunilyadav, just wondering if you might be interested in taking a look at this PR given that you reported the original issue (#409), and had helped out during the issue discussions?

It's working for us in production, by modifying our app's composer.json to use this branch:

Screenshot 2025-05-12 at 3 11 06 pm

Also @Kyon147 I'd really appreciate your eyes on this when you can.

Thanks

@Kyon147
Copy link
Owner

Kyon147 commented May 12, 2025

Hey @thejamescollins

Thanks for the PR, I'll take a look this week and spin it up on a new app so I can check the flow works for the old way and new way.

p.s great work btw 🙏 i'll give it a proper code review shortly.

Copy link
Owner

@Kyon147 Kyon147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just need to spin up a test to go through and check the flow for both.

@Kyon147
Copy link
Owner

Kyon147 commented May 14, 2025

@thejamescollins are you also able to update the wiki to include your new logic?

Either we add to https://github.com/Kyon147/laravel-shopify/wiki/Authentication-Process or we create a new page about the managed installation itself. Happy for you to decide which place is best for it.

@thesunilyadav
Copy link

Hi @thesunilyadav, just wondering if you might be interested in taking a look at this PR given that you reported the original issue (#409), and had helped out during the issue discussions?

It's working for us in production, by modifying our app's composer.json to use this branch:

Screenshot 2025-05-12 at 3 11 06 pm Also @Kyon147 I'd really appreciate your eyes on this when you can.

Thanks

Hi @thejamescollins,
Thank you very much for your contribution! I'll take a deeper look into the installation/uninstallation process over the weekend to ensure everything works smoothly without any breaking issues.

@Kyon147
Copy link
Owner

Kyon147 commented May 18, 2025

Hey @thejamescollins

This is looking good on my end, I just want to re-test it again today but will merge it in the week 🙏

@Kyon147 Kyon147 merged commit ddee18f into Kyon147:master May 25, 2025
18 checks passed
@Kyon147
Copy link
Owner

Kyon147 commented May 25, 2025

This is good for release @thejamescollins will sort a new release out tomorrow.

Will bump up a minor version as it is a backwards compatible change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Access Token Not Generated When Using Shopify Managed Installation Flow With Version (v19.1)

3 participants