-
-
Notifications
You must be signed in to change notification settings - Fork 158
Adds support for Shopify's Managed App Installation including Session Token Exchange #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Shopify's Managed App Installation including Session Token Exchange #415
Conversation
Restore previous behaviour while also adding in new managed auth flow
Hi @thesunilyadav, just wondering if you might be interested in taking a look at this PR given that you reported the original issue (#409), and had helped out during the issue discussions? It's working for us in production, by modifying our app's ![]() Also @Kyon147 I'd really appreciate your eyes on this when you can. Thanks |
Hey @thejamescollins Thanks for the PR, I'll take a look this week and spin it up on a new app so I can check the flow works for the old way and new way. p.s great work btw 🙏 i'll give it a proper code review shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just need to spin up a test to go through and check the flow for both.
@thejamescollins are you also able to update the wiki to include your new logic? Either we add to https://github.com/Kyon147/laravel-shopify/wiki/Authentication-Process or we create a new page about the managed installation itself. Happy for you to decide which place is best for it. |
Hi @thejamescollins, |
Hey @thejamescollins This is looking good on my end, I just want to re-test it again today but will merge it in the week 🙏 |
This is good for release @thejamescollins will sort a new release out tomorrow. Will bump up a minor version as it is a backwards compatible change. |
Adds support for Shopify's Managed App Installation and its Session Token Exchange.
See #409 for detailed discussions and steps.
Fixes #409