[SPARK-39857][SQL] V2ExpressionBuilder uses the wrong LiteralValue da… #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta type for In predicate (Kyligence#535) When building V2 `In` Predicate in `V2ExpressionBuilder`, `InSet.dataType` (which is `BooleanType`) is used to build the `LiteralValue`, `InSet.child.dataType` should be used instead. bug fix no new test Closes apache#37271 from huaxingao/inset. Authored-by: huaxingao <huaxin_gao@apple.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> Co-authored-by: huaxingao <huaxin_gao@apple.com>
zheniantoushipashi
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ta type for In predicate (#535)
When building V2
InPredicate inV2ExpressionBuilder,InSet.dataType(which isBooleanType) is used to build theLiteralValue,InSet.child.dataTypeshould be used instead.bug fix
no
new test
Closes apache#37271 from huaxingao/inset.
Authored-by: huaxingao huaxin_gao@apple.com
Signed-off-by: Dongjoon Hyun dongjoon@apache.org
Signed-off-by: Dongjoon Hyun dongjoon@apache.org
Co-authored-by: huaxingao huaxin_gao@apple.com
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?