Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting up draft #3

Merged
merged 3 commits into from
Mar 7, 2017
Merged

Add setting up draft #3

merged 3 commits into from
Mar 7, 2017

Conversation

Noviny
Copy link

@Noviny Noviny commented Mar 2, 2017

No description provided.

@Noviny
Copy link
Author

Noviny commented Mar 2, 2017

@KyleAMathews

Hey, for this one, I'm trying to add setting-up as a multi-part guide, so you'll end up with paths such as /guides/setting-up/installation however it is building as guides-setting-up/installation. I changed how kebab casing was working, but it didn't do the thing I was really looking for which was nest the setting-up under the guides.

These are still drafts, but wanted to make sure this problem didn't become a blocker.

@KyleAMathews
Copy link
Owner

KyleAMathews commented Mar 2, 2017 via email

@KyleAMathews KyleAMathews merged commit e4ed8cd into KyleAMathews:add-website Mar 7, 2017
@KyleAMathews
Copy link
Owner

This is live now 🎉

BTW, who needs to review this PR to get it merged? I'd rather all these doc changes live on master + the site get auto-rebuilt on Netlfy on a more official URL.

@Noviny
Copy link
Author

Noviny commented Mar 7, 2017

🎉 indeed!

Going to try and get a clear path for this to go live today.

@KyleAMathews
Copy link
Owner

Sweet!

@Noviny
Copy link
Author

Noviny commented Mar 8, 2017

Still don't have a definitive answer. Have a question though.

Probably going to look at making the sidebar more nested, with the ability to dig further in to topics. Is it still best to do this through yaml? Can we generate this dynamically?

@KyleAMathews
Copy link
Owner

Yeah, that's definitely doable — the markdown headings are exposed on the MarkdownRemark type.

screen shot 2017-03-08 at 9 07 58 am

So query that and then match the heading info with the paths & order expressed in the YAML file. The one trick would be where to query for headings. Probably the right solution would be to add support for adding graphql queries in layout components as currently they're only supported in page/template components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants