Update app icons #31
Update app icons #31
Conversation
|
Thanks a lot for updating the app icon for Forumate. Would you mind updating the existing Forumate.sketch file in Resources or provide a new Sketch or Figma file? @FradSer |
|
Also looks like that tvOS app icon is not included. The original Forumate.sketch include everything you need. Maybe you can just edit/update the file and export all the icon we need. Or you may need add such tvOS variants manually in your Figma file. 
|
|
A new tvOS app icon already updated, also check the Figma resource link which provide tvOS icons. |
.gitignore
Outdated
There was a problem hiding this comment.
I'd prefer to use a local .gitignore file for most of time. If a .gitignore has to be added into a repo.(Eg. some Swift package plugin will generate some intermediate file in the project folder), only necessary items should be added instead of adding a giant gitignore file. For this reason, maybe we can delete this commit?
There was a problem hiding this comment.
.gitignore removed in 7906cca .
Resources/Forumate.fig
Outdated
There was a problem hiding this comment.
- Maybe we can preserve the old sketch file.
- Wow, this file is unexpected large as 14MB. Can we delete some of the unused elements? Or if we all agree this file will not be deleted and will be a permanent link. We can add a Forumate-Icon.md file to replace the binary file and add the link in the markdown file.
There was a problem hiding this comment.
Figma file removed in c1b1199 , and replaced it with a markdown file.
README.md
Outdated
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| A native client to access Discourse server for Apple Platforms. | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
We'd better use a 256@2x/512 size image otherwise it will be too big to show in the README.(Or you can use some html trick to resize it)[Not recommended].
There was a problem hiding this comment.
Fixed in 4f9238a .
This reverts commit 377eabc.
|
The PR is generally OK for me now and when you are ready we can squash and merge it. But one optional refinement is update the AccentColor in this PR together. The original accent color uses dark purple since the original icon use black as the background. The new icon is very light maybe we should change the AccentColor accordingly. |
|
The accent color update to blue and pink like image below which LGTM. I think it time to close the PR, plz check the changes and merge this PR. |
Co-authored-by: Kyle <[email protected]>
Fixed #16