Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TranslatorBundle] Remove forced import from admin interface #2911

Merged
merged 2 commits into from
Jul 27, 2021
Merged

[TranslatorBundle] Remove forced import from admin interface #2911

merged 2 commits into from
Jul 27, 2021

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Jul 27, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

This option is too dangerous for admin users to accidentally click on it and overwrite all translations. It's still possible to do a forced import from the cli.

In the second commit I removed the incorrect deprecation on the command

@acrobat acrobat added this to the 5.9.0 milestone Jul 27, 2021
ProfessorKuma
ProfessorKuma approved these changes Jul 27, 2021
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat merged commit d5d7cf1 into Kunstmaan:master Jul 27, 2021
@acrobat acrobat deleted the remove-forced-import-interface branch July 27, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Feature Type: Improvement
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@acrobat @ProfessorKuma