Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AllBundles] Fix doctrine common deprecations and resolve doctrine bundle v2 incompatibility #2899

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Jul 10, 2021

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #2898

@acrobat acrobat added this to the 5.9.0 milestone Jul 10, 2021
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat
Copy link
Member Author

acrobat commented Jul 10, 2021

@KevinSleegers can you check if this PR fixes the generate command incompatibility with doctrineBundle v2? Thanks!

@acrobat acrobat force-pushed the doctrine-compatibility-fixes branch from a6ee28f to 84dbdaa Compare July 10, 2021 16:01
@acrobat acrobat force-pushed the doctrine-compatibility-fixes branch from 84dbdaa to 59f081a Compare July 10, 2021 16:04
@acrobat acrobat merged commit 1af2dfc into Kunstmaan:master Jul 13, 2021
@acrobat acrobat deleted the doctrine-compatibility-fixes branch July 13, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GeneratorBundle] Generate commands not working
2 participants