Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TranslatorBundle] Increase max length for translation domain #2895

Merged
merged 1 commit into from
Jul 4, 2021
Merged

[TranslatorBundle] Increase max length for translation domain #2895

merged 1 commit into from
Jul 4, 2021

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Jun 30, 2021

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #2893

ProfessorKuma
ProfessorKuma approved these changes Jun 30, 2021
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat added this to the 5.9.0 milestone Jul 4, 2021
@acrobat acrobat merged commit 5a2c2da into Kunstmaan:master Jul 4, 2021
@acrobat
Copy link
Member

acrobat commented Jul 4, 2021

Thanks @dannyvw!

@dannyvw dannyvw deleted the translation-domain branch July 4, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Improvement
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dannyvw @acrobat @ProfessorKuma