-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AdminBundle] New login styling #2888
Conversation
dbeerten
commented
Jun 10, 2021
•
edited by acrobat
Loading
edited by acrobat
Q | A |
---|---|
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Fixed tickets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @, your PR needs some changes
- Your answer if this PR is a bugfix seems to be incorrect.
- Your answer if this PR is a new feature seems to be incorrect.
- Your answer if this PR is BC breaking seems to be incorrect.
- Your answer if this PR is has deprecations seems to be incorrect.
- your PR title should look like
[SomeBundle] Fixed some code
} | ||
</style> #} | ||
|
||
{# {% include "@KunstmaanAdmin/Default/_css_extra.html.twig" %}#} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to uncomment or remove this line? (and uncomment line 35?)
@@ -0,0 +1,196 @@ | |||
{# TODO: html template, teksten in translations #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove todo comment
@@ -1,6 +1,9 @@ | |||
{% extends '@KunstmaanAdmin/authentication/layout.html.twig' %} | |||
|
|||
{% block login_content %} | |||
<h2 class="app-login__form-title"> | |||
Log in to {{ websitetitle | trans }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to move this to a translation key
src/Kunstmaan/AdminBundle/Resources/views/authentication/login.html.twig
Show resolved
Hide resolved
{% block login_footer %} | ||
<footer class="app-login__footer"> | ||
<p class="app-login__footer__text"> | ||
<img src="/bundles/kunstmaanadmin/default-theme/img/kunstmaan/logo-cms-color.svg" class="app-login__footer__logo"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the asset
function around the image path?
</header> | ||
|
||
<figure class="app-login__image-holder"> | ||
{% set login_image_url = '/bundles/kunstmaanadmin/default-theme/img/kunstmaan/default-login-bg.jpg' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the asset
function around the image path?
src/Kunstmaan/AdminBundle/Resources/views/authentication/layout.html.twig
Outdated
Show resolved
Hide resolved
src/Kunstmaan/AdminBundle/Resources/views/authentication/layout.html.twig
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @, your PR needs some changes
- This PR seems to need a milestone of a minor release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @, your PR passed all our requirements.
Thank you for contributing!
* master: [AdminBundle] Finish version checker deprecations [TranslatorBundle] Remove forced import from admin interface [TranslatorBundle] Remove incorrect deprecation, class will be renamed [AdminBundle] New login styling (#2888)