Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AllBundles] Mark event classes final #2861

Merged
merged 1 commit into from
Apr 25, 2021
Merged

[AllBundles] Mark event classes final #2861

merged 1 commit into from
Apr 25, 2021

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Apr 9, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

Mark all kunstmaan event classes as final, because overriding them doesn't change the dispatched event and it will make it easier to do changes in the future

@acrobat acrobat added this to the 5.9.0 milestone Apr 9, 2021
ProfessorKuma
ProfessorKuma approved these changes Apr 9, 2021
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat merged commit 1ebea69 into Kunstmaan:master Apr 25, 2021
@acrobat acrobat deleted the event-classes-final branch April 25, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Improvement
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@acrobat @ProfessorKuma