Fix wgpu 26 and wasm-bindgen 0.2.100 upgrade compatibility issues#1
Draft
Copilot wants to merge 3 commits intowgpu-upgradefrom
Draft
Fix wgpu 26 and wasm-bindgen 0.2.100 upgrade compatibility issues#1Copilot wants to merge 3 commits intowgpu-upgradefrom
Copilot wants to merge 3 commits intowgpu-upgradefrom
Conversation
Co-authored-by: Kumpelinus <174106140+Kumpelinus@users.noreply.github.com>
Co-authored-by: Kumpelinus <174106140+Kumpelinus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Summarize what happened / the problems of the PR @emilk/egui/pull/7340 . How would you prefer to fix it?
Fix wgpu 26 and wasm-bindgen 0.2.100 upgrade compatibility issues
Sep 14, 2025
Owner
|
The command to reproduce the issue is: |
fcb7591 to
62bcd8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the blocking issues from PR emilk#7340 to successfully upgrade wgpu from 25.0.0 to 26.0.1 and wasm-bindgen from 0.2.97 to 0.2.100.
Problem
The original PR emilk#7340 was stuck due to compilation errors when upgrading to wgpu 26. The main issues were:
Root Cause
wgpu 26 introduced breaking API changes that required additional fields:
InstanceDescriptornow requiresmemory_budget_thresholdsfieldRenderPassColorAttachmentnow requiresdepth_slicefieldSolution
Applied minimal, surgical fixes to address the API changes:
API Compatibility Fixes
memory_budget_thresholds: wgpu::MemoryBudgetThresholds::default()toInstanceDescriptorinsetup.rsdepth_slice: Noneto allRenderPassColorAttachmentstructs across:crates/egui-wgpu/src/capture.rscrates/egui-wgpu/src/winit.rscrates/eframe/src/web/web_painter_wgpu.rscrates/egui_kittest/src/wgpu.rs{e}to{e:?}in device pollingVersion Updates
25.0.0→26.0.10.2.97→0.2.100in CI workflows and demo appsetup_web.shscript for new wasm-bindgen versionDependency Cleanup
ndk-sysfromdeny.tomlskip list (confirmed deduplicated by upgrade)Verification
✅ All core functionality tested and working:
egui-wgpu) builds successfullyegui_kittest) builds successfullyNotes
The concerns about puffin/no_std compatibility mentioned in PR emilk#7340 comments turned out to be unfounded - profiling works perfectly with wgpu 26. The core issue was simply missing required fields in the new wgpu API, which this PR addresses with minimal changes.
Closes emilk#7340
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.