Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout configurable #101

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Timeout configurable #101

wants to merge 3 commits into from
+97 −16

Conversation

didierofrivia
Copy link
Contributor

@didierofrivia didierofrivia commented Oct 4, 2024 •
edited
Loading

Closes #93

Example config:

extensions:
  limitador:
    type: "ratelimit",
    endpoint: "limitador-cluster",
    failureMode: "deny",
    timeout: "5s"
policies:
...

The timeout value must be string, and must be in the format of a duration. Default to 20ms

Examples

  • 1ms parses as 1 millisecond
  • 1.5ms parses as 1 millisecond and 500 microseconds
  • 5s parses as 5 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsnaps alexsnaps Awaiting requested review from alexsnaps

@eguzki eguzki Awaiting requested review from eguzki

@adam-cattermole adam-cattermole Awaiting requested review from adam-cattermole

@roivaz roivaz Awaiting requested review from roivaz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Kuadrant
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the timeout of the rate limit request configurable
1 participant
@didierofrivia