Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the timeout of the rate limit request configurable #93

Open
roivaz opened this issue Oct 2, 2024 · 2 comments · May be fixed by #101
Open

Make the timeout of the rate limit request configurable #93

roivaz opened this issue Oct 2, 2024 · 2 comments · May be fixed by #101
Assignees

Comments

@roivaz
Copy link

roivaz commented Oct 2, 2024

The current timeout value is 5s and not configurable (see code). Also, 5 seconds seems way too high. A more sensible default could be 20ms, same as the envoy ratelimit filter uses.

@alexsnaps
Copy link
Member

To be considered whether we'd want 2 of these, or say one "per service", as I could see Authorino needing a different value than Limitador

@adam-cattermole
Copy link
Member

I'd say that we include it as part of the extension configuration in the wasm-shim so that it's configurable by service, the same way as the failure mode.

@didierofrivia didierofrivia self-assigned this Oct 4, 2024
@didierofrivia didierofrivia linked a pull request Oct 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

4 participants