-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly update pipeline using Helm deploy #50
Conversation
e3eaae4
to
c7d6db7
Compare
Tools do not need redeploy. The helm-install-nightly pipeline can just reinstall kuadrant and keep tools deployed as they were. That needs sparation of tools deploy with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azgabur I haven't tried yet, no real issues just a few questions. I will approve once I will try on clean cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried both pipelines on a clean cluster several times and it worked - meaning they finished successfully and Kuadrant was installed. LGTM
@azgabur It would be nice to squash commits ;) |
40c0ce2
to
68dd606
Compare
Now you really really can do re-review :) |
@azgabur sorry for late reply, I think I will be able to get to this this week. Could you please rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
^ just a rebase @averevki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried on clean cluster installing Kuadrant v1 rc6. All good.
Signed-off-by: Alex Zgabur <[email protected]>
Signed-off-by: Alex Zgabur <[email protected]>
Signed-off-by: Alex Zgabur <[email protected]>
Replaces #39
Closes #41
This nightly-update-pipeline can update specified cluster to newest nightly using helm deploy.
The deploy pipeline can install any choosen Kuadrant image on specified cluster.
Done:
image
,channel
of kuadrant and maybe other variables