Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly update pipeline using Helm deploy #50

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

azgabur
Copy link
Contributor

@azgabur azgabur commented Oct 30, 2024

Replaces #39
Closes #41

This nightly-update-pipeline can update specified cluster to newest nightly using helm deploy.
The deploy pipeline can install any choosen Kuadrant image on specified cluster.

Done:

  • Add cron job running the pipeline daily
  • Add parameters for specifying image, channel of kuadrant and maybe other variables
  • Refactor to using helm commands instead of bash install script
  • Refactor to using helm commands instead of bash uninstall script (maybe)

@azgabur
Copy link
Contributor Author

azgabur commented Oct 31, 2024

Tools do not need redeploy. The helm-install-nightly pipeline can just reinstall kuadrant and keep tools deployed as they were. That needs sparation of tools deploy with kuadrant namespace deployment

Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azgabur I haven't tried yet, no real issues just a few questions. I will approve once I will try on clean cluster.

deploy/pipeline-nightly-update.yaml Outdated Show resolved Hide resolved
tasks/02-uninstall.yaml Outdated Show resolved Hide resolved
tasks/02-uninstall.yaml Outdated Show resolved Hide resolved
trepel
trepel previously approved these changes Nov 5, 2024
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried both pipelines on a clean cluster several times and it worked - meaning they finished successfully and Kuadrant was installed. LGTM

@trepel
Copy link
Contributor

trepel commented Nov 5, 2024

@azgabur It would be nice to squash commits ;)

deploy/pipeline-nightly-update.yaml Outdated Show resolved Hide resolved
tasks/02-uninstall.yaml Outdated Show resolved Hide resolved
tasks/01-clone.yaml Outdated Show resolved Hide resolved
deploy/pipeline.yaml Outdated Show resolved Hide resolved
tasks/01-clone.yaml Outdated Show resolved Hide resolved
tasks/01-clone.yaml Outdated Show resolved Hide resolved
tasks/kustomization.yaml Outdated Show resolved Hide resolved
@azgabur
Copy link
Contributor Author

azgabur commented Nov 13, 2024

Ready for re-review @trepel @averevki

@azgabur
Copy link
Contributor Author

azgabur commented Nov 14, 2024

Now you really really can do re-review :)

@trepel
Copy link
Contributor

trepel commented Nov 19, 2024

@azgabur sorry for late reply, I think I will be able to get to this this week. Could you please rebase?

averevki
averevki previously approved these changes Nov 19, 2024
Copy link
Contributor

@averevki averevki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deploy/eventlistener.yaml Show resolved Hide resolved
@azgabur
Copy link
Contributor Author

azgabur commented Nov 20, 2024

^ just a rebase @averevki

Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried on clean cluster installing Kuadrant v1 rc6. All good.

Filip Čáp and others added 3 commits November 21, 2024 12:58
@azgabur azgabur merged commit 1b1ad9c into Kuadrant:main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kuadrant deploy/update using helm and OLM pipeline
3 participants