Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust env for the new dns provider secret #40

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Adjust env for the new dns provider secret #40

merged 1 commit into from
Aug 30, 2024

Conversation

averevki
Copy link
Contributor

No description provided.

@averevki averevki self-assigned this Aug 26, 2024
trepel
trepel approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@trepel trepel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried but it seems reasonable. If I got it right the nightly pipeline is already configured like this and is working fine so LGTM

@averevki averevki merged commit e429fbd into Kuadrant:main Aug 30, 2024
2 checks passed
@averevki averevki deleted the change-gcp-secret branch August 30, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azgabur azgabur azgabur approved these changes

@trepel trepel trepel approved these changes

Assignees

@averevki averevki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averevki @trepel @azgabur