Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make upload-results task optional #38

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

averevki
Copy link
Contributor

Closes #27

@averevki averevki added the enhancement New feature or request label Aug 12, 2024
@averevki averevki requested a review from azgabur August 12, 2024 16:23
@averevki averevki self-assigned this Aug 12, 2024
@averevki averevki force-pushed the make-upload-results-optional branch from b683dbc to bf3b124 Compare August 12, 2024 16:25
Copy link
Contributor

@azgabur azgabur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tekton.dev/docs/pipelines/pipelines/#param-enum I would really like to use the enum type here as there will be just two allowed values "true" and "false" but this feature is still in alpha and not supported on Openshift without some modification. Otherwise looking good, lgtm!

@averevki averevki requested a review from trepel August 19, 2024 13:29
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would improve description to explicitly state that this is meant to be boolean value (despite actually being of string type).
And I would also consider saying that everything except for "true" is treated as false.

But that's minor stuff, approving

@averevki averevki merged commit 24d7f2a into Kuadrant:main Aug 30, 2024
2 checks passed
@averevki averevki deleted the make-upload-results-optional branch August 30, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make report portal step optional
3 participants