Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix additional-env export #28

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Fix additional-env export #28

merged 1 commit into from
Aug 30, 2024

Conversation

averevki
Copy link
Contributor

No description provided.

@averevki averevki added the bug Something isn't working label Jul 15, 2024
@averevki averevki requested a review from ficap July 15, 2024 17:25
trepel
trepel approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, both with and without additional env vars it works

@averevki averevki merged commit abb2c21 into Kuadrant:main Aug 30, 2024
1 check passed
@averevki averevki deleted the fix-additional-env branch August 30, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azgabur azgabur azgabur approved these changes

@trepel trepel trepel approved these changes

@ficap ficap Awaiting requested review from ficap

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averevki @trepel @azgabur