go 1.20; controller-runtime v0.14.6 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
commented
Sep 1, 2023
| @@ -105,24 +101,20 @@ func (r *LimitadorReconciler) Reconcile(eventCtx context.Context, req ctrl.Reque | |||
| return ctrl.Result{}, nil | |||
| } | |||
|
|
|||
| func (r *LimitadorReconciler) reconcileSpec(ctx context.Context, limitadorObj *limitadorv1alpha1.Limitador) (ctrl.Result, error) { | |||
| func (r *LimitadorReconciler) reconcileSpec(ctx context.Context, limitadorObj *limitadorv1alpha1.Limitador) error { | |||
There was a problem hiding this comment.
I do not like this, but I was forced by the lint tool 😠
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 51.83% 50.85% -0.99%
==========================================
Files 13 13
Lines 897 879 -18
==========================================
- Hits 465 447 -18
+ Misses 394 391 -3
- Partials 38 41 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KevFan
requested changes
Sep 4, 2023
|
Updated with |
KevFan
reviewed
Sep 4, 2023
KevFan
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sigs.k8s.io/controller-runtimev0.14.6Aligning to tech stack of https://github.com/Kuadrant/kuadrant-operator