Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov: do not fail ci on error #87

Merged
merged 2 commits into from
Aug 11, 2023
Merged

codecov: do not fail ci on error #87

merged 2 commits into from
Aug 11, 2023

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Aug 10, 2023

  • Prevent codecov from failing ci on error due to flakiness with codecov upload
  • Use CODECOV_TOKEN for upload that should at least prevent upload issue when PRs come from branches from this repo

KevFan added 2 commits August 10, 2023 15:25
Prevents upload flakiness when PRs come from branches in this repo
@KevFan KevFan requested a review from a team August 10, 2023 14:35
@codecov-commenter
Copy link

Codecov Report

Merging #87 (a28eb36) into main (0fa98ed) will increase coverage by 2.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   43.31%   45.40%   +2.08%     
==========================================
  Files          11       11              
  Lines         718      718              
==========================================
+ Hits          311      326      +15     
+ Misses        369      358      -11     
+ Partials       38       34       -4     
Flag Coverage Δ
unit 45.40% <ø> (+2.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KevFan KevFan added kind/bug Something isn't working participation/good first issue Good for newcomers size/small labels Aug 10, 2023
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@KevFan KevFan merged commit 5381563 into Kuadrant:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working participation/good first issue Good for newcomers size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants