-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog post for installing grafana on openshift #68
Add blog post for installing grafana on openshift #68
Conversation
✅ Deploy Preview for relaxed-faloodeh-7fa6f1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
left minor comments
name: grafana-operator | ||
source: community-operators | ||
sourceNamespace: openshift-marketplace | ||
startingCSV: grafana-operator.v5.15.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pinning to a particular version? startingCSV
is not really needed, unless you want a particular version, which may not exists now or in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realise it was optional
I'll remove it as installing the latest version sounds reasonable
be4afef
to
273ba80
Compare
|
Signed-off-by: David Martin <[email protected]>
273ba80
to
0f376b1
Compare
Thanks for reviewing @jsmolar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: david-martin, eguzki, jasonmadigan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Uses latest v5 version of operator.
I based the post on https://cloud.redhat.com/experts/o11y/ocp-grafana/ (which uses v4),
but with a kuadrant spin on it as it's for the kuadrant blog.