Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post for installing grafana on openshift #68

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

david-martin
Copy link
Contributor

Uses latest v5 version of operator.
I based the post on https://cloud.redhat.com/experts/o11y/ocp-grafana/ (which uses v4),
but with a kuadrant spin on it as it's for the kuadrant blog.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for relaxed-faloodeh-7fa6f1 ready!

Name Link
🔨 Latest commit 0f376b1
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-faloodeh-7fa6f1/deploys/6731e1acf2279100089e51db
😎 Deploy Preview https://deploy-preview-68--relaxed-faloodeh-7fa6f1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

left minor comments

name: grafana-operator
source: community-operators
sourceNamespace: openshift-marketplace
startingCSV: grafana-operator.v5.15.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinning to a particular version? startingCSV is not really needed, unless you want a particular version, which may not exists now or in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realise it was optional
I'll remove it as installing the latest version sounds reasonable

src/blog/grafana-on-openshift-for-kuadrant.md Show resolved Hide resolved
@david-martin david-martin force-pushed the grafana-on-openshift-for-kuadrant-obs branch from be4afef to 273ba80 Compare November 8, 2024 15:25
@jsmolar
Copy link

jsmolar commented Nov 11, 2024

@david-martin david-martin force-pushed the grafana-on-openshift-for-kuadrant-obs branch from 273ba80 to 0f376b1 Compare November 11, 2024 10:51
@david-martin
Copy link
Contributor Author

Thanks for reviewing @jsmolar
I've added a note about the token potentially expiring (with a link to openshift docs),
and a note about having user workload monitoring enabled (again, with a link to openshift docs).

Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, eguzki, jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [david-martin,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonmadigan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 41b8688 into main Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants