Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog nav with initial post #61

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Add blog nav with initial post #61

merged 2 commits into from
Aug 6, 2024

Conversation

david-martin
Copy link
Contributor

  • Adds a new blog top nav page that shows blog posts
  • Adds a first blog post to announce the CNCF sandbox project acceptance - posts go in the src/blog folder with metadata at top of md file
  • Removes the anchor id links for Features, Components & FAQs from the top nav and 'Useful Links' at the bottom to make room for the Blog nav item
  • Styling changes and icon addition to the top nav (see comparison screenshot)

Nav before:
image

Nav after:
image

@jasonmadigan I'd appreciate any suggestions on how to make the blog landing page a little nicer looking. Any suggestions on the individual blog post page are also welcome.

The blog layout & template is partially copied from https://github.com/11ty/eleventy-base-blog/tree/main (MIT licence)

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for relaxed-faloodeh-7fa6f1 ready!

Name Link
🔨 Latest commit f842c4b
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-faloodeh-7fa6f1/deploys/66acfbb0199cd200080fb1c8
😎 Deploy Preview https://deploy-preview-61--relaxed-faloodeh-7fa6f1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this all looks good to me. Not for now, but if we do have a lot of posts, we may want to look at pagination.

@jasonmadigan
Copy link
Member

/lgtm
/approve

@david-martin
Copy link
Contributor Author

Nice, this all looks good to me. Not for now, but if we do have a lot of posts, we may want to look at pagination.

yeah, that makes sense.
I'm toying with this as the layout for the top blog landing page.
Thoughts?
Maybe remove the numbering

image

@jasonmadigan
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2024
Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [david-martin,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4797c13 into main Aug 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants