fix: Add policy conflict to dnspolicy validation #995
Merged
+138
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
commented
Nov 8, 2024
api/v1/tlspolicy_types.go
Outdated
| @@ -191,7 +191,7 @@ func (p *TLSPolicy) GetRulesHostnames() []string { | |||
| return make([]string, 0) | |||
| } | |||
|
|
|||
| // DEPRECATED: Use GetTargetRefs instead | |||
| // Deprecated: kuadrant.Policy. | |||
There was a problem hiding this comment.
"Deprecated:" seems to be the correct way to do this in Go https://go.dev/wiki/Deprecated, linter will fail if this is used anywhere.
We can likely remove all these soon anyway, if not already.
There was a problem hiding this comment.
Actually, they all are in #992
mikenairn
commented
Nov 8, 2024
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
These are pretty much copied from the TLSPolicy, we should probably look at making generic functions that can be used by both.
Updates the dnspolicies validator task to check for polices with conflicting target refs, only one policy can currently target a specific gateway or listener. Uses the same logic as TLS, first policy created is given preference over any created later. Some other small changes to align DNSPolicy and TLSPolicy. Signed-off-by: Michael Nairn <[email protected]>
mikenairn
force-pushed
the
dnspolicy_validation_policy_conflict
branch
from
e40b44b
to
3ca2c69
Compare
maleck13
approved these changes
Nov 10, 2024
maleck13
pushed a commit
that referenced
this pull request
Nov 13, 2024
Updates the dnspolicies validator task to check for polices with conflicting target refs, only one policy can currently target a specific gateway or listener. Uses the same logic as TLS, first policy created is given preference over any created later. Some other small changes to align DNSPolicy and TLSPolicy. Signed-off-by: Michael Nairn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the dnspolicies validator task to check for polices with conflicting target refs, only one policy can currently target a specific gateway or listener. Uses the same logic as TLS, first policy created is given preference over any created later.
Some other small changes to align DNSPolicy and TLSPolicy.