REFACTOR: Kuadtrant Status #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the old controller logic for reconciling the kuadrant status to the state of the world workflow. Signed-off-by: Jim Fitzpatrick <[email protected]>
Boomatang
force-pushed
the
kuadrant/status
branch
from
81fb841
to
2d810b9
Compare
guicassolato
reviewed
Nov 8, 2024
Comment on lines
+80
to
+82
| // maistra.io permissions | ||
| // +kubebuilder:rbac:groups=maistra.io,resources=servicemeshcontrolplanes,verbs=get;list;watch;update;use;patch | ||
| // +kubebuilder:rbac:groups=maistra.io,resources=servicemeshmembers,verbs=get;list;watch;create;update;delete;patch |
There was a problem hiding this comment.
These are not needed anymore.
Suggested change
| // maistra.io permissions | |
| // +kubebuilder:rbac:groups=maistra.io,resources=servicemeshcontrolplanes,verbs=get;list;watch;update;use;patch | |
| // +kubebuilder:rbac:groups=maistra.io,resources=servicemeshmembers,verbs=get;list;watch;create;update;delete;patch |
guicassolato
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Left one minor comment, but I'm happy to address it in #992 if we want to get this one merged first.
|
@guicassolato thanks for the quick review, I think we merge it and address the mistra.io comment in #992 |
maleck13
pushed a commit
that referenced
this pull request
Nov 13, 2024
Move the old controller logic for reconciling the kuadrant status to the state of the world workflow. Signed-off-by: Jim Fitzpatrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the old controller logic for reconciling the kuadrant status to the state of the world workflow.
This works the same as before with one main change that ensures status of the kuadrant CR is updated when resources are created out of order. For example if a user wanted to deploy limitador that was redis backed they can now create the the limitador resources a head of time.