Support HTTPQueryParamMatch as CEL routeRuleConditions #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Snaps <[email protected]>
alexsnaps
commented
Nov 5, 2024
| // from https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/advanced/attributes | ||
| // request.query -> string : The query portion of the URL in the format of “name1=value1&name2=value2”. | ||
| // query param, only consider the first in case of repetition, as per spec | ||
| queryParams := make(map[gatewayapiv1.HTTPHeaderName]bool) |
There was a problem hiding this comment.
Dunno if that's idiomatic Go...
There was a problem hiding this comment.
its fine, I think you would find most use queryParams := map[gatewaypiv1.HTTPHeaderName]bool{} but I don't think it is that important
maleck13
reviewed
Nov 6, 2024
Signed-off-by: Alex Snaps <[email protected]>
Signed-off-by: Alex Snaps <[email protected]>
Signed-off-by: Alex Snaps <[email protected]>
alexsnaps
force-pushed
the
cel_query_params
branch
from
8a14ebe
to
61661d2
Compare
|
So I don't know how this makes math... but there is no way this introduces a regression in test coverage as it tests my additions as well as code that wasn't test before... Go home codecov, You're drunk! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #981 +/- ##
==========================================
- Coverage 76.15% 76.10% -0.05%
==========================================
Files 111 111
Lines 8986 8998 +12
==========================================
+ Hits 6843 6848 +5
- Misses 1852 1853 +1
- Partials 291 297 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Depends on Kuadrant/wasm-shim#126 |
eguzki
approved these changes
Nov 7, 2024
maleck13
pushed a commit
that referenced
this pull request
Nov 13, 2024
* Support HTTPQueryParamMatch as CEL routeRuleConditions Signed-off-by: Alex Snaps <[email protected]> * By default decodeQueryString will now ignore repeated params Signed-off-by: Alex Snaps <[email protected]> * By default queryMap will now ignore repeated params Signed-off-by: Alex Snaps <[email protected]> * Test for mapping `HTTPRouteMatch` to CEL Predicates Signed-off-by: Alex Snaps <[email protected]> --------- Signed-off-by: Alex Snaps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.