chore: TLS and DNS Policy API cleanup #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mikenairn
commented
Nov 1, 2024
•
mikenairn
commented
- Remove unnecessary implementation of kuadrant.Referrer
- Mark implementation of kuadrant.Policy as Deprecated
- Avoid the use of Kind() method in DNS/TLS policy validator/status tasks
- Set type of missing resource to Gateway rather than the Policy. This isn't 100% correct since it could be a section name not found, but it's closer than using the policy.
* Remove unnescaery implementation of kuadrant.Referrer * Mark implementation of kuadrant.Policy as Deprecated * Avoid the use of Kind() method in DNS/TLS policy validator tasks * Set type of missing resource to Gateway rather than the Policy. This isn't 100% correct since it could be a section name not found, but it's closer than using the policy. Signed-off-by: Michael Nairn <[email protected]>
mikenairn
force-pushed
the
prep_tls_and_dns_apis
branch
from
c7e15c8
to
36283a9
Compare
KevFan
approved these changes
Nov 1, 2024
guicassolato
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.