Script #917
Script #917
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
==========================================
- Coverage 81.49% 81.43% -0.07%
==========================================
Files 102 115 +13
Lines 7177 7507 +330
==========================================
+ Hits 5849 6113 +264
- Misses 898 966 +68
+ Partials 430 428 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
R-Lawton
force-pushed
the
script
branch
6 times, most recently
from
e3e3497
to
2e66854
Compare
…o longer created with istio being installed by sail Signed-off-by: R-Lawton <[email protected]>
|
@maleck13 Looking at the different types of observability pieces in didn't make sense to just overlay the namespace as envoy and istio have different ports and selectors etc. Split out what was needed by istio into its own separate kustomise that the quickstart deploys and the same for envoy that standalone observability doc installs. Both also still deploy the obvserve pieces that oringally were there require. |
| @@ -2,7 +2,7 @@ apiVersion: telemetry.istio.io/v1alpha1 | |||
| kind: Telemetry | |||
| metadata: | |||
| name: namespace-metrics | |||
| namespace: gateway-system | |||
| namespace: istio-system | |||
There was a problem hiding this comment.
Telemetry resource is a istio thing not a envoy resource. Envoy has there own version but that can be post v1
The quickstart script was failing as a namespace was missing. The namespace no longer gets installed with the preferred documented method of installing istio via sail. The script should finish properly now and the observability piece should install without issues
KUADRANT_REF=script ./hack/quickstart-setup.sh