-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sotw: event predicates #915
Conversation
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
==========================================
+ Coverage 80.20% 81.49% +1.28%
==========================================
Files 64 102 +38
Lines 4492 7177 +2685
==========================================
+ Hits 3603 5849 +2246
- Misses 600 898 +298
- Partials 289 430 +141
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Guilherme Cassolato <[email protected]>
github.com/kuadrant/policy-machinery v0.2.0 | ||
github.com/kuadrant/policy-machinery v0.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hadn't realised main
was so much behind. In fact, this explains why I was observing multiple stale update events related to the topology ConfigMap at another branch but not really in main
.
Added another commit, shamelessly stolen from @KevFan, to widen the change to all kinds of resources watched by the SOTW reconciler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 💯
Filter
topology configmapevents with generation-changed predicate type.