Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sotw: event predicates #915

Merged
merged 3 commits into from
Oct 8, 2024
Merged

sotw: event predicates #915

merged 3 commits into from
Oct 8, 2024

Conversation

guicassolato
Copy link
Contributor

@guicassolato guicassolato commented Oct 7, 2024

Filter topology configmap events with generation-changed predicate type.

@guicassolato guicassolato self-assigned this Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.49%. Comparing base (ece13e8) to head (63f1d28).
Report is 228 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
+ Coverage   80.20%   81.49%   +1.28%     
==========================================
  Files          64      102      +38     
  Lines        4492     7177    +2685     
==========================================
+ Hits         3603     5849    +2246     
- Misses        600      898     +298     
- Partials      289      430     +141     
Flag Coverage Δ
bare-k8s-integration 8.89% <57.94%> (?)
controllers-integration 65.32% <85.98%> (?)
envoygateway-integration 50.30% <85.98%> (?)
gatewayapi-integration 14.40% <71.96%> (?)
integration ?
istio-integration 53.51% <85.98%> (?)
unit 28.34% <0.00%> (-1.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.90% <100.00%> (+19.48%) ⬆️
api/v1beta2 (u) 86.61% <81.94%> (-4.82%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 71.51% <ø> (-2.40%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 85.83% <ø> (+6.37%) ⬆️
controllers (i) 83.06% <83.04%> (+6.25%) ⬆️
Files with missing lines Coverage Δ
controllers/state_of_the_world.go 97.23% <100.00%> (ø)

... and 57 files with indirect coverage changes

Signed-off-by: Guilherme Cassolato <[email protected]>
github.com/kuadrant/policy-machinery v0.2.0
github.com/kuadrant/policy-machinery v0.5.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't realised main was so much behind. In fact, this explains why I was observing multiple stale update events related to the topology ConfigMap at another branch but not really in main.

Added another commit, shamelessly stolen from @KevFan, to widen the change to all kinds of resources watched by the SOTW reconciler.

@guicassolato guicassolato changed the title sotw: generation-changed predicate for topology configmap events sotw: event predicates Oct 7, 2024
Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💯

@guicassolato guicassolato merged commit b333a12 into main Oct 8, 2024
28 of 29 checks passed
@guicassolato guicassolato deleted the sotw/topology-predicate branch October 8, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants