Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorino version v0.18.0 #898

Merged
merged 2 commits into from
Oct 2, 2024
Merged

authorino version v0.18.0 #898

merged 2 commits into from
Oct 2, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Oct 2, 2024

No description provided.

Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
@eguzki eguzki added the kind/enhancement New feature or request label Oct 2, 2024
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.21%. Comparing base (ece13e8) to head (80ae0e1).
Report is 208 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
+ Coverage   80.20%   81.21%   +1.00%     
==========================================
  Files          64       89      +25     
  Lines        4492     6940    +2448     
==========================================
+ Hits         3603     5636    +2033     
- Misses        600      885     +285     
- Partials      289      419     +130     
Flag Coverage Δ
bare-k8s-integration 6.78% <ø> (?)
controllers-integration 72.67% <ø> (?)
envoygateway-integration 49.82% <ø> (?)
gatewayapi-integration 12.45% <ø> (?)
integration ?
istio-integration 53.67% <ø> (?)
unit 28.99% <ø> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 84.61% <100.00%> (+13.18%) ⬆️
api/v1beta2 (u) 81.25% <75.17%> (-10.18%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 71.51% <ø> (-2.40%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 85.39% <ø> (+5.93%) ⬆️
controllers (i) 82.54% <82.51%> (+5.74%) ⬆️

see 49 files with indirect coverage changes

@@ -72,6 +72,7 @@ require (
github.com/exponent-io/jsonpath v0.0.0-20210407135951-1de76d718b3f // indirect
github.com/fatih/color v1.17.0 // indirect
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/foxcpp/go-mockdns v1.1.0 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this is not strictly related to bumping github.com/kuadrant/authorino, but I guess it's OK?

Comment on lines -144 to -146
github.com/tidwall/gjson v1.14.0 // indirect
github.com/tidwall/match v1.1.1 // indirect
github.com/tidwall/pretty v1.2.0 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ones disappearing from the list of dependencies kinds of surprises me. Has Go become smarter on knowing this part of Authorino's code is not reached by the Kuadrant Operator maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blame go mod tidy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'm gonna trust this is good news.

@eguzki
Copy link
Contributor Author

eguzki commented Oct 2, 2024

Only failing license compliance analysis. This is due to Fossa issue.. I have re run the analysis 3 times, however, it seems to be stuck.

Screenshot 2024-10-02 at 14-43-46 kuadrant-operator - Projects FOSSA

Merging this regardless of the license compliance analysis

@eguzki eguzki merged commit 4793dc4 into main Oct 2, 2024
29 of 31 checks passed
@eguzki eguzki deleted the bump-authorino-version branch October 2, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants