Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog only needs default channel #880

Merged
merged 2 commits into from
Sep 27, 2024
Merged

catalog only needs default channel #880

merged 2 commits into from
Sep 27, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Sep 27, 2024

No description provided.

Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
@eguzki eguzki marked this pull request as ready for review September 27, 2024 08:26
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.48%. Comparing base (ece13e8) to head (740d157).
Report is 193 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
+ Coverage   80.20%   80.48%   +0.27%     
==========================================
  Files          64       91      +27     
  Lines        4492     7101    +2609     
==========================================
+ Hits         3603     5715    +2112     
- Misses        600      964     +364     
- Partials      289      422     +133     
Flag Coverage Δ
bare-k8s-integration 6.63% <ø> (?)
controllers-integration 72.60% <ø> (?)
envoygateway-integration 48.38% <ø> (?)
gatewayapi-integration 12.24% <ø> (?)
integration ?
istio-integration 52.00% <ø> (?)
unit 27.54% <ø> (-2.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 84.61% <100.00%> (+13.18%) ⬆️
api/v1beta2 (u) 81.25% <75.17%> (-10.18%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 70.95% <ø> (-2.96%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 84.26% <ø> (+4.81%) ⬆️
controllers (i) 82.74% <81.09%> (+5.94%) ⬆️

see 44 files with indirect coverage changes

@eguzki eguzki mentioned this pull request Sep 27, 2024
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Copy link
Collaborator

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eguzki eguzki merged commit a43c40e into main Sep 27, 2024
31 checks passed
@eguzki eguzki deleted the missing-manifests-info branch September 27, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants