Add an excludeAddresses option in DNSPolicy #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleck13
force-pushed
the
gh-496
branch
2 times, most recently
from
119aa45
to
f2a5c62
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
==========================================
+ Coverage 80.20% 81.45% +1.24%
==========================================
Files 64 101 +37
Lines 4492 7133 +2641
==========================================
+ Hits 3603 5810 +2207
- Misses 600 899 +299
- Partials 289 424 +135
Flags with carried forward coverage won't be shown. Click here to find out more.
|
philbrookes
reviewed
Sep 24, 2024
philbrookes
approved these changes
Sep 24, 2024
|
LGTM, other than the failing checks. Nice to see we got CIDR ranges included. |
maleck13
changed the title
maleck13
force-pushed
the
gh-496
branch
2 times, most recently
from
f98e33f
to
342b90a
Compare
mikenairn
reviewed
Sep 27, 2024
|
ignore this for a bit |
|
closes #496 |
maleck13
force-pushed
the
gh-496
branch
5 times, most recently
from
d1e23a6
to
b44cbc0
Compare
maleck13
commented
Oct 3, 2024
| @@ -125,6 +130,9 @@ type DNSPolicyStatus struct { | |||
|
|
|||
| // +optional | |||
| RecordConditions map[string][]metav1.Condition `json:"recordConditions,omitempty"` | |||
| // TotalRecords records the total number of individual DNSRecords managed by this DNSPolicy | |||
| // +optional | |||
| TotalRecords int32 `json:"totalRecords,omitempty"` | |||
There was a problem hiding this comment.
@mikenairn added this maybe not needed? Thought it was a useful thing and planned to use it elsewhere
maleck13
force-pushed
the
gh-496
branch
7 times, most recently
from
72bdb20
to
c3aa8c7
Compare
Signed-off-by: craig <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED add integration test for excludeAddresses updates post rebase add total records to status. Add additional status message info fix-integration update status and tests add doc update dnspolicy ref helm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: craig [email protected]
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED