Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix flaky dnspolicy test #854

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

mikenairn
Copy link
Member

@mikenairn mikenairn commented Sep 12, 2024

Flaky test:

 Summarizing 1 Failure:
  [FAIL] DNSPolicy controller valid target and valid gateway status [It] should re-create dns record when listener hostname changes
  /home/runner/work/kuadrant-operator/kuadrant-operator/tests/common/dnspolicy/dnspolicy_controller_test.go:766

Failed on the scheduled nightly job: https://github.com/Kuadrant/kuadrant-operator/actions/runs/10822642839/job/30026825858

Caused by not waiting long enough for the records to become ready again, increased the timeout on the check.

Flaky test:
```
 Summarizing 1 Failure:
  [FAIL] DNSPolicy controller valid target and valid gateway status [It] should re-create dns record when listener hostname changes
  /home/runner/work/kuadrant-operator/kuadrant-operator/tests/common/dnspolicy/dnspolicy_controller_test.go:766
```

Caused by not waiting long enough for the records to become ready again, increased the timout on the check.

Signed-off-by: Michael Nairn <[email protected]>
@mikenairn mikenairn merged commit 316728b into Kuadrant:main Sep 12, 2024
22 checks passed
@mikenairn mikenairn deleted the fix_dnspolicy_test branch September 12, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants