Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra patch step and change naming #740

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

R-Lawton
Copy link
Contributor

@R-Lawton R-Lawton commented Jul 8, 2024

WHAT:

Updating the naming of the metrics service to be cohesive and inline with the other operators and be easier for users. Removing the extra patch step for the metrics port to be inline with other operators

Verification

export KUADRANT_ORG=R-Lawton                                                     
export KUADRANT_REF=naming
hack/quickstart-setup.sh

Ensure the service gets created with the new naming:

kubectl get services kuadrant-operator-metrics -n kuadrant-system

Ensure the deployment gets created with the metrics port 8080 exposed.
kubectl get deployments kuadrant-operator-controller-manager -n kuadrant-system -o yaml

@R-Lawton R-Lawton requested a review from a team as a code owner July 8, 2024 09:18
@R-Lawton R-Lawton changed the title remove extra patch step and change naming to be inline with other ope… remove extra patch step and change naming Jul 8, 2024
@R-Lawton R-Lawton merged commit ffdea67 into Kuadrant:main Jul 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants