istio-optional: iteration 2

[eguzki]

Second iteration of the "Have Istio optional" story.

Basically, this is about making the wasm package not coupled with any gateway provider. Additionally, field indexers are declared globally at main.go instead of by some controller.

part of #325

Depends on #645

[codecov]

Codecov Report

Attention: Patch coverage is 79.28994% with 35 lines in your changes missing coverage. Please review.

Project coverage is 82.91%. Comparing base (ece13e8) to head (ba7b3ce).
Report is 114 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   80.20%   82.91%   +2.70%     
==========================================
  Files          64       76      +12     
  Lines        4492     5755    +1263     
==========================================
+ Hits         3603     4772    +1169     
- Misses        600      650      +50     
- Partials      289      333      +44     

Flag	Coverage Δ
bare-k8s-integration	4.58% <8.87%> (?)
controllers-integration	72.57% <72.78%> (?)
gatewayapi-integration	11.08% <7.69%> (?)
integration	?
istio-integration	55.95% <76.33%> (?)
unit	32.55% <28.57%> (+2.52%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api/v1beta1 (u)	71.42% <ø> (ø)
api/v1beta2 (u)	93.58% <100.00%> (+2.16%)	⬆️
pkg/common (u)	88.13% <ø> (-0.70%)	⬇️
pkg/istio (u)	73.88% <ø> (-0.03%)	⬇️
pkg/log (u)	94.73% <ø> (ø)
pkg/reconcilers (u)	∅ <ø> (∅)
pkg/rlptools (u)	81.96% <ø> (+2.50%)	⬆️
controllers (i)	82.06% <80.66%> (+5.26%)	⬆️

Files	Coverage Δ
...llers/rate_limiting_istio_wasmplugin_controller.go	80.50% <100.00%> (ø)
...lers/ratelimitpolicy_enforced_status_controller.go	83.33% <100.00%> (ø)
controllers/target_status_controller.go	90.16% <100.00%> (ø)
controllers/test_common.go	100.00% <100.00%> (ø)
pkg/rlptools/utils.go	100.00% <100.00%> (ø)
pkg/rlptools/wasm/utils.go	86.66% <92.85%> (ø)
pkg/library/fieldindexers/httproute_parents.go	65.00% <65.00%> (ø)
pkg/rlptools/wasm/types.go	44.44% <53.33%> (-5.56%)	⬇️
pkg/istio/mutators.go	55.55% <55.55%> (ø)
pkg/rlptools/topology_index.go	72.97% <72.97%> (ø)

... and 31 files with indirect coverage changes

[KevFan]

Initial scan looks good, but requires a rebase. I'll have a look again once PR has been rebased

[eguzki]

@KevFan rebased and conflicts fixed. Ready for a new review.

Thanks

[eguzki]

This codecov report is not accurate

Looking at the codecov website, actually it is green

[KevFan]

Changes looks good me to me 🏅