tests: Use inmemory provider backed managed zones #658
+98
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
commented
May 28, 2024
philbrookes
approved these changes
May 28, 2024
|
/hold Will merge after Kuadrant/dns-operator#142 |
mikenairn
force-pushed
the
inmemory_managed_zones
branch
2 times, most recently
from
73d4654
to
36c4fd5
Compare
|
does this need an unhold? Why are the integration tests being skipped? |
Test are doing weird things for some reason, triggered them again. Hold did nothing, prow isn't even enabled on this repo. |
mikenairn
force-pushed
the
inmemory_managed_zones
branch
2 times, most recently
from
ef9b749
to
43c5713
Compare
philbrookes
approved these changes
Jun 6, 2024
Update all DNSPolicy integration tests to use the inmemory provider. If the dns operator is running on the target cluster managedzones and dnsrecords should work as if they are targeting a real DNS Provider. Enable aws, google and inmemory providers in local deployment of dns operator.
mikenairn
force-pushed
the
inmemory_managed_zones
branch
from
43c5713
to
4baa88f
Compare
dlaw4608
pushed a commit
to dlaw4608/kuadrant-operator
that referenced
this pull request
Jun 17, 2024
Update all DNSPolicy integration tests to use the inmemory provider. If the dns operator is running on the target cluster managedzones and dnsrecords should work as if they are targeting a real DNS Provider. Enable aws, google and inmemory providers in local deployment of dns operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #601
Update all DNSPolicy integration tests to use the inmemory provider. If the dns operator is running on the target cluster managedzones and dnsrecords should work as if they are targeting a real DNS Provider.
Requires: Kuadrant/dns-operator#142