Skip to content

add catalogsource to install doc #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024
Merged

add catalogsource to install doc #619

merged 1 commit into from
May 6, 2024

Conversation

maleck13
Copy link
Collaborator

@maleck13 maleck13 commented May 6, 2024

add docs to install via catalogsource directly

@maleck13 maleck13 requested a review from a team as a code owner May 6, 2024 16:42
Copy link
Member

@alexsnaps alexsnaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if we want to merge this yet necessarily, but yeah...

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.74%. Comparing base (ece13e8) to head (c1da18e).
Report is 70 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #619       +/-   ##
===========================================
- Coverage   80.20%   32.74%   -47.47%     
===========================================
  Files          64       65        +1     
  Lines        4492     4957      +465     
===========================================
- Hits         3603     1623     -1980     
- Misses        600     3240     +2640     
+ Partials      289       94      -195     
Flag Coverage Δ
integration ?
unit 32.74% <ø> (+2.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
api/v1beta2 (u) 47.43% <53.33%> (-44.00%) ⬇️
pkg/common (u) 77.47% <ø> (-11.35%) ⬇️
pkg/istio (u) 44.37% <ø> (-29.54%) ⬇️
pkg/log (u) 36.84% <ø> (-57.90%) ⬇️
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 57.25% <ø> (-22.21%) ⬇️
controllers (i) 8.80% <4.87%> (-68.00%) ⬇️

see 49 files with indirect coverage changes

@maleck13
Copy link
Collaborator Author

maleck13 commented May 6, 2024

I will merge for now. If we get the operator released to operator hub will revert

@maleck13 maleck13 merged commit 1937542 into main May 6, 2024
22 of 23 checks passed
maleck13 added a commit that referenced this pull request May 7, 2024
* add catalogsource to install doc (#619)

* minor docs updates

* more missing code quotes
@eguzki eguzki deleted the add-catalog-source branch June 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants