Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Allow parallel execution of DNS and TLS Policy tests #583

Merged
merged 1 commit into from
Apr 29, 2024
Merged

tests: Allow parallel execution of DNS and TLS Policy tests #583

merged 1 commit into from
Apr 29, 2024
+9 −15

Conversation

mikenairn
Copy link
Member

@mikenairn mikenairn commented Apr 26, 2024 •
edited
Loading

Creates a unique gateway class per test case and removes Ordered from the TLS policy tests.

Parallel (30.102542988s):

./bin/ginkgo -p --procs 20 --focus "DNSPolicy" --focus "TLSPolicy" --skip "Target status reconciler" -tags integration ./controllers/...
Running Suite: Controller Suite - /home/mnairn/go/src/github.com/kuadrant/kuadrant-operator/controllers
=======================================================================================================
Random Seed: 1714117888

Will run 31 of 147 specs
Running in parallel across 20 processes
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS••••••SSSSSSSSSSSSS••SSSS•••••SSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•••••••••••••••••

Ran 31 of 147 Specs in 23.773 seconds
SUCCESS! -- 31 Passed | 0 Failed | 0 Pending | 116 Skipped


Ginkgo ran 1 suite in 30.102542988s
Test Suite Passed

Serial(4m21.733588392s):

./bin/ginkgo --focus "DNSPolicy" --focus "TLSPolicy" --skip "Target status reconciler" -tags integration ./controllers/...
Running Suite: Controller Suite - /home/mnairn/go/src/github.com/kuadrant/kuadrant-operator/controllers
=======================================================================================================
Random Seed: 1714117926

Will run 31 of 147 specs
••••••SSSSSSSSSSSSSSSSSSSSSSSSS•••••••••••••SSSSSSSSSSSS••••••••••••SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

Ran 31 of 147 Specs in 255.389 seconds
SUCCESS! -- 31 Passed | 0 Failed | 0 Pending | 116 Skipped
PASS

Ginkgo ran 1 suite in 4m21.733588392s
Test Suite Passed

Created follow on task to look into using the istio gateway class since that's what all the other policy tests (Auth and RLP) are doing #582

@mikenairn mikenairn requested a review from a team as a code owner April 26, 2024 07:51
@mikenairn mikenairn mentioned this pull request Apr 26, 2024
Closed
maleck13
maleck13 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mikenairn
tests: Allow parallel execution of DNS and TLS Policy tests
01e7137 
Creates a unique gateway class per test case and removes `Ordered` from
the TLS policy tests.

```
./bin/ginkgo -p --procs 20 --focus "DNSPolicy" --focus "TLSPolicy" --skip "Target status reconciler" -tags integration ./controllers/...
```
@mikenairn mikenairn merged commit 854cd7f into Kuadrant:main Apr 29, 2024
13 checks passed
@mikenairn mikenairn deleted the parallel_tests branch April 29, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philbrookes philbrookes philbrookes approved these changes

@maleck13 maleck13 maleck13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikenairn @maleck13 @philbrookes