Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing guide #568

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Tracing guide #568

merged 3 commits into from
Apr 25, 2024

Conversation

david-martin
Copy link
Contributor

closes Kuadrant/docs.kuadrant.io#70

A follow up PR will add this to the docs site.

@david-martin david-martin requested a review from a team as a code owner April 23, 2024 16:27
@david-martin
Copy link
Contributor Author

@adam-cattermole I'd appreciate your review.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #568 (4ef36b6) into main (ece13e8) will decrease coverage by 48.26%.
Report is 49 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #568       +/-   ##
===========================================
- Coverage   80.20%   31.95%   -48.26%     
===========================================
  Files          64       65        +1     
  Lines        4492     4913      +421     
===========================================
- Hits         3603     1570     -2033     
- Misses        600     3250     +2650     
+ Partials      289       93      -196     
Flag Coverage Δ
integration ?
unit 31.95% <ø> (+1.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
api/v1beta2 (u) 47.43% <53.33%> (-44.00%) ⬇️
pkg/common (u) 77.47% <ø> (-11.35%) ⬇️
pkg/istio (u) 44.37% <ø> (-29.54%) ⬇️
pkg/log (u) 36.84% <ø> (-57.90%) ⬇️
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 57.25% <ø> (-22.21%) ⬇️
controllers (i) 7.23% <0.00%> (-69.58%) ⬇️

see 49 files with indirect coverage changes

Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a couple suggestions here but mostly looks good

doc/observability/tracing.md Outdated Show resolved Hide resolved
doc/observability/tracing.md Show resolved Hide resolved
doc/observability/tracing.md Outdated Show resolved Hide resolved
doc/observability/tracing.md Outdated Show resolved Hide resolved
doc/observability/tracing.md Show resolved Hide resolved
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates lgtm!

@david-martin david-martin merged commit 0285586 into main Apr 25, 2024
19 of 21 checks passed
maleck13 pushed a commit that referenced this pull request Apr 25, 2024
* Add tracing guide

* Update doc/observability/tracing.md

Co-authored-by: Adam Cattermole <[email protected]>

* Address feedback

---------

Co-authored-by: Adam Cattermole <[email protected]>
@eguzki eguzki deleted the tracing-guide branch June 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Guide for configuring tracing
2 participants