-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing guide #568
Tracing guide #568
Conversation
@adam-cattermole I'd appreciate your review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
===========================================
- Coverage 80.20% 31.95% -48.26%
===========================================
Files 64 65 +1
Lines 4492 4913 +421
===========================================
- Hits 3603 1570 -2033
- Misses 600 3250 +2650
+ Partials 289 93 -196
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got a couple suggestions here but mostly looks good
Co-authored-by: Adam Cattermole <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates lgtm!
* Add tracing guide * Update doc/observability/tracing.md Co-authored-by: Adam Cattermole <[email protected]> * Address feedback --------- Co-authored-by: Adam Cattermole <[email protected]>
closes Kuadrant/docs.kuadrant.io#70
A follow up PR will add this to the docs site.