Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: speed & other minor improvements #565

Merged
merged 20 commits into from
Apr 26, 2024
Merged

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Apr 23, 2024

Some refactoring to improve testing speed and other minor changes:

  • Remove deploying toystore app
    • This is not used at all and deleting a namespace with it deployed takes a lot longer than without (i.e. this can compound for each test and therefore increase the overall test suite runtime)
  • Deploy single kuadrant install in BeforeAll/AfterAll in seperate namespace
    • Installing kuadrant takes time and is generally shared between tests so there is no need to set it each time in BeforeEach
    • Tests with these stages must be mark as Ordered. For now this is okay until we are able to run the tests concurrently
  • Use spec context and timeouts per spec
  • Remove unnecessart docker build in test workflow
    • Image is never deployed as part of integration test as the test suite itself runs the controller reconcilers

Integreation test time in now ~34 mins (down from over an hour previously)

@KevFan KevFan changed the title [wip] tests [wip] tests: fixes and minor improvements Apr 24, 2024
@KevFan KevFan force-pushed the tests branch 3 times, most recently from 75a60d0 to 6957c1a Compare April 25, 2024 14:05
@KevFan KevFan changed the title [wip] tests: fixes and minor improvements tests: speed improvements Apr 26, 2024
@KevFan KevFan changed the title tests: speed improvements tests: minor improvements Apr 26, 2024
@KevFan KevFan mentioned this pull request Apr 26, 2024
@KevFan KevFan marked this pull request as ready for review April 26, 2024 13:18
@KevFan KevFan requested a review from a team as a code owner April 26, 2024 13:18
@KevFan
Copy link
Contributor Author

KevFan commented Apr 26, 2024

image

Ran integration tests with the latest changes on CI 6 times already and all passed which suggests the changes might be stable now.

Average runtime in now 34mins with these changes

@KevFan KevFan changed the title tests: minor improvements tests: speed & other minor improvements Apr 26, 2024
@KevFan
Copy link
Contributor Author

KevFan commented Apr 26, 2024

Last 10 integration test runs has all passed so the changes here are stable at least

image

Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅 Gold! Awesome job, @KevFan! Thank you!

@guicassolato guicassolato merged commit b22f9ee into Kuadrant:main Apr 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants