-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: speed & other minor improvements #565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevFan
force-pushed
the
tests
branch
4 times, most recently
from
April 25, 2024 11:54
d5c24d6
to
1936094
Compare
KevFan
force-pushed
the
tests
branch
3 times, most recently
from
April 25, 2024 14:05
75a60d0
to
6957c1a
Compare
building docker image as part of test workflow in unnecessary as the image in never deployed and the reconcilers are started as part of the test suite
KevFan
changed the title
[wip] tests: fixes and minor improvements
tests: speed improvements
Apr 26, 2024
Closed
KevFan
changed the title
tests: minor improvements
tests: speed & other minor improvements
Apr 26, 2024
guicassolato
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅 Gold! Awesome job, @KevFan! Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring to improve testing speed and other minor changes:
BeforeEach
Ordered
. For now this is okay until we are able to run the tests concurrentlyBeforeEach
time also uses this same timeout (https://onsi.github.io/ginkgo/#the-spectimeout-and-nodetimeout-decorators).Eventually
will use this context as timeout and should exit the assertion quicker which makes the overall test complete fasterIntegreation test time in now ~34 mins (down from over an hour previously)