Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge various downstream tweaks to dashboards #555

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

david-martin
Copy link
Contributor

@david-martin david-martin commented Apr 19, 2024

This is a combined set of recent changes from a downstream focused deliverable.

Dashboards should import cleanly & work for both prometheus and thanos data sources. (Though with prometheus, the exported_namespace labels would need to be changed to have the template variables be populated. Dashboards should still work.)

For upstream, the dashboard tags & list name includes the name 'kuadrant'.

app developer:
image

business user:
image

platform engineer:
image

@david-martin david-martin requested a review from a team as a code owner April 19, 2024 11:48
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Merging #555 (3eccd94) into main (ece13e8) will decrease coverage by 47.02%.
Report is 40 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #555       +/-   ##
===========================================
- Coverage   80.20%   33.19%   -47.02%     
===========================================
  Files          64       65        +1     
  Lines        4492     4676      +184     
===========================================
- Hits         3603     1552     -2051     
- Misses        600     3033     +2433     
+ Partials      289       91      -198     
Flag Coverage Δ
integration ?
unit 33.19% <ø> (+3.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
api/v1beta2 (u) 51.92% <77.41%> (-39.51%) ⬇️
pkg/common (u) 81.13% <ø> (-7.70%) ⬇️
pkg/istio (u) 44.37% <100.00%> (-29.54%) ⬇️
pkg/log (u) 36.84% <ø> (-57.90%) ⬇️
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 57.25% <ø> (-22.21%) ⬇️
controllers (i) 7.80% <0.00%> (-69.01%) ⬇️

see 48 files with indirect coverage changes

@david-martin david-martin merged commit 82aaff3 into main Apr 23, 2024
20 of 22 checks passed
@david-martin david-martin deleted the dashboard-updates branch April 23, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants