Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the app developer dashboard #540

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Conversation

david-martin
Copy link
Contributor

@david-martin david-martin commented Apr 11, 2024

Follow up on #526
Closes #435

In addition to the changes add in #526, also includes:

  • repeating row per API/HTTPRoute
  • more compact view of all data already included
  • consistent colours for success/error/%
  • %ile color gradient
  • text box at top to explain dashboard & row repeating
  • tooltips updated

image

@david-martin david-martin requested a review from a team as a code owner April 11, 2024 17:13
Copy link
Contributor

@R-Lawton R-Lawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great much prefer the more compact design

also:
- consistent colours for success/error/%
- text box at top to explain dashboard & row repeating
- %ile color gradient
@david-martin david-martin merged commit e23aa8d into Kuadrant:main Apr 12, 2024
12 checks passed
@david-martin david-martin deleted the gh-435 branch April 12, 2024 15:06
@thomasmaas
Copy link
Contributor

thomasmaas commented Apr 12, 2024

Screenshot 2024-04-12 at 17 16 19

I know this has already been merged, wondering if for a next iteration it might make sense to combine these boxes in 1 column so you don't get the label duplication. And maybe add a percentage so it's easier to get an idea of the error rate quickly?

total
0,43 r/s (380 r, 100 %)
success
0,43 r/s (321 r, 84 %)
error
0,43 r/s (59 r, 6 %)

@david-martin
Copy link
Contributor Author

Thanks for the suggestion @thomasmaas.
It would definitely look less cluttered without the title duplication.
We're at the mercy of what you can do with grafana panels, though I do think there's a way to have multiple queries in a single state that appear horizontal or vertical. Could be a way of doing that. Or a table view, though we moved away from that as the single stats allow customisation on the text color.

Would you mind creating a new issue for that if you feel strongly. (There's actually a shortcut to reference your comment in a new issue that I haven't used before. Might be useful)

Thanks

philbrookes pushed a commit that referenced this pull request Apr 16, 2024
* adding refined app developer dashboard and telemetry piece

* spelling mistake

* adding kustomise telemetry

* Add a repeating row with more compact panels

also:
- consistent colours for success/error/%
- text box at top to explain dashboard & row repeating
- %ile color gradient

---------

Co-authored-by: R-Lawton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine & release the App Developer dashboard from the API Quickstart
3 participants